Skip to content

flow: update halo sizes for multiple designs#4351

Merged
eder-matheus merged 17 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-mpl-halo-on-pins
Jul 24, 2026
Merged

flow: update halo sizes for multiple designs#4351
eder-matheus merged 17 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-mpl-halo-on-pins

Conversation

@joaomai

@joaomai joaomai commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This PR adjusts the MACRO_PLACE_HALO value across multiple designs in order to accommodate the changes to halos introduced by #10558. Some metrics updates are also needed.

@joaomai joaomai self-assigned this Jul 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MACRO_PLACE_HALO configuration values across several design platforms, including asap7, gf12, nangate45, and sky130hd, and updates the tools/OpenROAD submodule commit. I have no feedback to provide.

@joaomai joaomai added the UpdateRules Starts GHA to update rules label Jul 14, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label Jul 14, 2026
@openroad-ci
openroad-ci force-pushed the secure-mpl-halo-on-pins branch from 6c69592 to e392360 Compare July 22, 2026 21:13
@joaomai joaomai added the UpdateRules Starts GHA to update rules label Jul 23, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label Jul 23, 2026
@joaomai joaomai added UpdateRules Starts GHA to update rules and removed UpdateRules Starts GHA to update rules labels Jul 23, 2026
joaomai added 15 commits July 23, 2026 22:01
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
designs/sky130hd/chameleon/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| synth__canonical_netlist__hash                | a279612250a1367c37ea08f7b0bb8a08ae725da3 | 3024027ad30e973f5b4459bd0e120c6c23ceb89e | Failing  |
| synth__netlist__hash                          | edd4949a57adadaae7b7d99d440f03eae351e498 | 8a1f4c88e692a05b73d7d3e5192e75e79822f1d5 | Failing  |
| cts__timing__setup__tns                       |     -373.0 |     -114.0 | Tighten  |
| globalroute__antenna_diodes_count             |        161 |        224 | Failing  |
| globalroute__timing__setup__ws                |      -2.35 |      -2.32 | Tighten  |
| globalroute__timing__setup__tns               |     -363.0 |      -42.9 | Tighten  |
| detailedroute__antenna_diodes_count           |        100 |        158 | Failing  |
| finish__timing__setup__ws                     |      -2.15 |      -2.06 | Tighten  |
| finish__timing__setup__tns                    |     -354.0 |      -39.9 | Tighten  |

Signed-off-by: João Mai <jmai@precisioninno.com>
designs/sky130hd/microwatt/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| synth__canonical_netlist__hash                | 642ebe77b86723b162e5f260e5abae1ad1003847 | af5777f8966cfeeed148e5f64a4f4fa1bf57d0f2 | Failing  |
| synth__netlist__hash                          | f6ccf3a646ec63990a474d9bdcb96fcfe1b7edde | a56d7ca3cd12435f18435d628cf578edc6082da8 | Failing  |
| placeopt__design__instance__area              |    5427782 |    5413510 | Tighten  |
| placeopt__design__instance__count__stdcell    |     184133 |     181940 | Tighten  |
| cts__design__instance__count__setup_buffer    |      16012 |      15821 | Tighten  |
| cts__design__instance__count__hold_buffer     |      16012 |      15821 | Tighten  |
| cts__timing__setup__tns                       |     -249.0 |     -326.0 | Failing  |
| globalroute__antenna_diodes_count             |       5162 |       1861 | Tighten  |
| globalroute__timing__setup__tns               |     -241.0 |     -256.0 | Failing  |
| detailedroute__route__wirelength              |    8240415 |    8076674 | Tighten  |
| detailedroute__antenna__violating__nets       |         10 |          0 | Tighten  |
| detailedroute__antenna_diodes_count           |       2411 |       1661 | Tighten  |
| finish__timing__setup__tns                    |     -236.0 |	   -258.0 | Failing  |

Signed-off-by: João Mai <jmai@precisioninno.com>
designs/nangate45/swerv_wrapper/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| synth__canonical_netlist__hash                | ae72f3b5b3c6b8883c8448eb3086b1310345c412 | 04876aa8597747afe76a824832e5cc47e7188033 | Failing  |
| synth__netlist__hash                          | 4960294d07ead3c1bd0d38e18b415d8b7a3cdfcd | 69293fd12a9316eb3db4f3ae97753fe26adb41e7 | Failing  |
| placeopt__design__instance__area              |     729155 |     727527 | Tighten  |
| placeopt__design__instance__count__stdcell    |     110775 |     106084 | Tighten  |
| cts__design__instance__count__setup_buffer    |       9633 |       9225 | Tighten  |
| cts__design__instance__count__hold_buffer     |       9633 |       9225 | Tighten  |
| cts__timing__setup__tns                       |     -422.0 |     -415.0 | Tighten  |
| globalroute__antenna_diodes_count             |        107 |        105 | Tighten  |
| globalroute__timing__setup__ws                |     -0.337 |     -0.466 | Failing  |
| globalroute__timing__setup__tns               |     -426.0 |     -438.0 | Failing  |
| detailedroute__antenna_diodes_count           |        107 |        106 | Tighten  |
| finish__timing__setup__tns                    |     -418.0 |     -384.0 | Tighten  |

Signed-off-by: João Mai <jmai@precisioninno.com>
designs/nangate45/tinyRocket/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| synth__canonical_netlist__hash                | 675929b98a2f4adc51e7ab08dc15383435147b74 | a044a2ec26d32ce5c142fe453bf2bb6c70d468e9 | Failing  |
| synth__netlist__hash                          | 414fc0fd97ec190c6e3f5c44e9ee1c249ba40234 | b130a04aa6e0139ef5a81a1134effc31a22505fc | Failing  |
| cts__timing__setup__ws                        |      -0.14 |     -0.201 | Failing  |
| cts__timing__setup__tns                       |      -54.5 |      -27.9 | Tighten  |
| globalroute__timing__setup__tns               |      -57.4 |      -49.7 | Tighten  |
| finish__timing__setup__tns                    |      -50.5 |      -47.7 | Tighten  |

Signed-off-by: João Mai <jmai@precisioninno.com>
Signed-off-by: João Mai <jmai@precisioninno.com>
@openroad-ci
openroad-ci force-pushed the secure-mpl-halo-on-pins branch from e392360 to 270ca66 Compare July 23, 2026 22:07
joaomai added 2 commits July 24, 2026 03:54
Signed-off-by: João Mai <jmai@precisioninno.com>
designs/sky130hd/microwatt/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| synth__canonical_netlist__hash                | af5777f8966cfeeed148e5f64a4f4fa1bf57d0f2 | a07cb0bb2ab74796be4909c263c6dff6da4b470a | Failing  |
| synth__netlist__hash                          | a56d7ca3cd12435f18435d628cf578edc6082da8 | 388289eb539881bcf988621a3b4daa444487f655 | Failing  |
| placeopt__design__instance__area              |    5413510 |    5408427 | Tighten  |
| placeopt__design__instance__count__stdcell    |     181940 |     181507 | Tighten  |
| cts__design__instance__count__setup_buffer    |      15821 |      15783 | Tighten  |
| cts__design__instance__count__hold_buffer     |      15821 |      15783 | Tighten  |
| cts__timing__setup__ws                        |      -2.43 |      -2.32 | Tighten  |
| cts__timing__setup__tns                       |     -326.0 |     -254.0 | Tighten  |
| globalroute__antenna_diodes_count             |       1861 |       1456 | Tighten  |
| globalroute__timing__setup__ws                |      -2.28 |      -2.21 | Tighten  |
| globalroute__timing__setup__tns               |     -256.0 |     -227.0 | Tighten  |
| detailedroute__antenna__violating__nets       |          0 |          1 | Failing  |
| detailedroute__antenna_diodes_count           |       1661 |       1219 | Tighten  |
| finish__timing__setup__ws                     |      -2.27 |      -2.16 | Tighten  |
| finish__timing__setup__tns                    |     -258.0 |     -215.0 | Tighten  |
| finish__timing__hold__ws                      |      -0.89 |     -0.883 | Tighten  |
| finish__timing__hold__tns                     |       -4.0 |      -3.42 | Tighten  |
| finish__design__instance__area                |    5570244 |    5568932 | Tighten  |

Signed-off-by: João Mai <jmai@precisioninno.com>
@joaomai

joaomai commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Paired with #10558 on OR.

@eder-matheus
eder-matheus self-requested a review July 24, 2026 14:26
@eder-matheus
eder-matheus merged commit 46ab264 into The-OpenROAD-Project:master Jul 24, 2026
8 checks passed
@eder-matheus
eder-matheus deleted the secure-mpl-halo-on-pins branch July 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants