[DO NOT MERGE] -- Test inline check PR comment#4374
Closed
migueldalberto wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Jenkinsfile to use a feature branch ('inline-check-pr-comment') for the shared library instead of the 'main' branch. The feedback advises reverting this change to a stable branch or version tag before merging to avoid potential pipeline failures if the feature branch is modified or deleted.
| @@ -1,4 +1,4 @@ | |||
| @Library('utils@main') _ | |||
| @Library('utils@inline-check-pr-comment') _ | |||
Contributor
There was a problem hiding this comment.
Referencing a feature branch ('inline-check-pr-comment') for the shared library is acceptable for testing, but it should be reverted to a stable branch (such as 'main') or a specific version tag before merging. This prevents pipeline failures if the feature branch is deleted or modified in the future.
@Library('utils@main') _
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 61 design(s) checked — 0 with regression(s), 8 without a comparable baseline.
|
Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
CORE_UTILIZATION=98 drove gcd placement to 134.7% utilization (GPL-0301), crashing the flow before metadata.json was written — so the inline QoR check had no metrics to compare and correctly reported inconclusive rather than the intended regression. Drop to 60 (~82% placed utilization): dense enough vs the 38 baseline to degrade timing/area past the alert thresholds, but below the placement crash ceiling so the flow finishes and emits metrics the check can flag. Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.