Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated REMOVE_ABC_BUFFERS configuration variable from the documentation, variable schemas, and scripts. In floorplan.tcl, setting this variable now raises an error indicating it is no longer supported, and the timing repair helper is executed unconditionally. Feedback on the changes suggests improving the Tcl conditional check for REMOVE_ABC_BUFFERS to robustly handle non-numeric boolean strings (like 'false' or 'no') to avoid triggering false-positive errors.
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
546f50c to
12f3cfb
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 34 design(s) checked — 1 with regression(s), 0 without a comparable baseline. ❌ ihp-sg13g2/aes base — 1 failing metric(s)
|
TL;DR removes REMOVE_ABC_BUFFERS completely from scripting, will go pr-merge green once designs are updated, ready for review.
Single-concern PR: remove all
REMOVE_ABC_BUFFERSsupport from the flow and documentation. Designs are left alone on purpose.floorplan.tclalways runsrepair_timing_helper, and theremove_buffersbranch is gone.variables.yaml, andvariables.jsonanddocs/user/FlowVariables.mdwere regenerated.After this PR,
REMOVE_ABC_BUFFERSonly appears inflow/designs/.Expected CI
pr-head is expected to fail while designs still set
REMOVE_ABC_BUFFERS, because their QoR changes. Once the design PRs below have merged, pr-merge goes green without any further change to this PR. So if we agree on the direction, this can get automerge now and it will land by itself when the prerequisites are done.Prerequisites (design updates):
flow/designs/asap7/minimal/config.mk(REMOVE_ABC_BUFFERS ?= 1) is not covered by any of the above yet🤖 Generated with Claude Code