Skip to content

Remove REMOVE_ABC_BUFFERS support - #4580

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-support
Open

oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-support

Conversation

@oharboe

@oharboe oharboe commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR removes REMOVE_ABC_BUFFERS completely from scripting, will go pr-merge green once designs are updated, ready for review.

Single-concern PR: remove all REMOVE_ABC_BUFFERS support from the flow and documentation. Designs are left alone on purpose.

  • floorplan.tcl always runs repair_timing_helper, and the remove_buffers branch is gone.
  • Removed from variables.yaml, and variables.json and docs/user/FlowVariables.md were regenerated.

After this PR, REMOVE_ABC_BUFFERS only appears in flow/designs/.

Expected CI

pr-head is expected to fail while designs still set REMOVE_ABC_BUFFERS, because their QoR changes. Once the design PRs below have merged, pr-merge goes green without any further change to this PR. So if we agree on the direction, this can get automerge now and it will land by itself when the prerequisites are done.

Prerequisites (design updates):

🤖 Generated with Claude Code

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated REMOVE_ABC_BUFFERS configuration variable from the documentation, variable schemas, and scripts. In floorplan.tcl, setting this variable now raises an error indicating it is no longer supported, and the timing repair helper is executed unconditionally. Feedback on the changes suggests improving the Tcl conditional check for REMOVE_ABC_BUFFERS to robustly handle non-numeric boolean strings (like 'false' or 'no') to avoid triggering false-positive errors.

Comment thread flow/scripts/floorplan.tcl Outdated
floorplan.tcl now always runs repair_timing_helper. The variable is
dropped from variables.yaml, variables.json and FlowVariables.md.

Designs are deliberately not touched here; they are handled by
The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe force-pushed the remove-abc-buffers-support branch from 546f50c to 12f3cfb Compare September 29, 2026 05:45
@oharboe
oharboe requested a review from maliberty September 29, 2026 05:45
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit eb221d5 · Jenkins build #2 · Baseline: build · View build on dashboard

34 design(s) checked — 1 with regression(s), 0 without a comparable baseline.

❌ ihp-sg13g2/aes base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__ws -0.624158 -0.518657 20.341188878198885% -0.618657 PeriodPadding 5.0%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants