Skip to content

chore: drop what the bazel surface removal left behind - #4806

Merged
vvbandeira merged 2 commits into
The-OpenROAD-Project:masterfrom
oharboe:chore/drop-bazel-leftovers
Nov 15, 2026
Merged

vvbandeira merged 2 commits into
The-OpenROAD-Project:masterfrom
oharboe:chore/drop-bazel-leftovers

Conversation

@oharboe

@oharboe oharboe commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Before: after #4501 and #4524 removed ORFS's bazel surface, a README, two doc sections, three files under bazel/ and two flow/util scripts still described or served that build. Following docs/user/BuildLocally.md or flow/README.md ends at a target that does not exist.
Now: they are gone. 396 lines deleted, nothing added.

Deleted Why nothing needs it
flow/README.md the per-design bazel targets and design.bzl, deleted in #4501
docs/user/BuildLocally.md, two bazel sections //:install_for_bazel, designs/asap7/gcd:gcd_floorplan and MODULE.bazel no longer exist
bazel/install.sh its only caller was //:install_for_bazel
bazel/README.md describes flow/BUILD.bazel and the MODULE.bazel pin
bazel/slang-compat/README needed only when ORFS is the root bazel module, which it can no longer be
flow/util/cred_helper.py GCP credentials for the removed bazel artifact repository; no references
flow/util/open_plots.sh wrapper for the plot_congestion target removed in #4085/#4096
/bazel/ in CODEOWNERS the directory is gone

.bazelversion and .bazelignore stay: docker/Dockerfile.claude installs bazelisk, which reads .bazelversion.

Check: git grep finds no remaining reference to any deleted path.

🤖 Generated with Claude Code

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes all Bazel build support, configuration files, helper scripts, and related documentation from the repository. This includes the deletion of Bazel-specific installation scripts, GCP credential helpers, and Bazel-related sections in the local build documentation. As there are no review comments provided, I have no feedback to offer.

The-OpenROAD-Project#4501 removed ORFS's MODULE.bazel and BUILD files, and c9e1ba4 the
plumbing that only they referenced. These files and doc sections
describe or serve that build, and nothing reads them now:

  flow/README.md               the bazel targets of every design
                               (<n>_synth, ..., <n>_test) and how to
                               add a design's BUILD.bazel. Those
                               targets and design.bzl are gone.

  docs/user/BuildLocally.md    "Using Bazel to build OpenROAD and run
                               the ORFS flow" runs `bazelisk run
                               //:install_for_bazel`, a target that
                               went with the root BUILD.bazel. "Build
                               OpenROAD and run a few ORFS flows with
                               Bazel" builds designs/asap7/gcd targets
                               and bumps a MODULE.bazel, neither of
                               which exists.

  bazel/install.sh             its only caller was //:install_for_bazel.
  bazel/README.md              describes flow/BUILD.bazel examples and
                               the bazel-orfs version pin in
                               MODULE.bazel.
  bazel/slang-compat/README    a placeholder for when ORFS is the root
                               module consuming tools/OpenROAD through
                               git_override. Without a MODULE.bazel,
                               ORFS is never the root module.

  flow/util/cred_helper.py     a GCP credential helper for the bazel
                               artifact repository (fabdb02);
                               nothing references it.
  flow/util/open_plots.sh      an xdg-open wrapper for the bazel
                               plot_congestion target, removed in
                               The-OpenROAD-Project#4085 and The-OpenROAD-Project#4096.

The /bazel/ line in CODEOWNERS goes with the directory.

.bazelversion and .bazelignore stay: bazelisk in
docker/Dockerfile.claude reads .bazelversion.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe force-pushed the chore/drop-bazel-leftovers branch from 7c0ad2a to 65f818c Compare November 8, 2026 11:07
@openroad-ci

openroad-ci commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit be9a448 · Jenkins build #4 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe marked this pull request as ready for review November 11, 2026 03:23
@oharboe
oharboe requested a review from a team as a code owner November 11, 2026 03:23
@oharboe
oharboe requested review from vvbandeira and removed request for a team November 11, 2026 03:23

@vvbandeira vvbandeira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flow/designs/README.md still documents the removed in-tree targets: design.bzl (line 12) and bazelisk test //flow/designs/... (lines 37-50).
flow/test/openroad.sh runs ./external/_main~_repo_rules~openroad/openroad, a Bazel external path, and nothing calls it.
Please delete both in this PR, or say why they stay.
The .github/dependabot.yml comment on MODULE.bazel (line 3) is now stale too.

Review follow-up. These also only served the removed bazel build:

  flow/designs/README.md   documents the design.bzl targets and
                           `bazelisk test //flow/designs/...`; neither
                           exists.
  flow/test/openroad.sh    runs openroad from a Bazel external repo
                           path; nothing calls it.
  .github/dependabot.yml   the comment that MODULE.bazel is not
                           covered; there is no MODULE.bazel.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe requested a review from vvbandeira November 15, 2026 16:53
@oharboe

oharboe commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator Author

@vvbandeira Fixed.

@vvbandeira
vvbandeira enabled auto-merge November 15, 2026 17:00
@vvbandeira
vvbandeira merged commit e5f2fea into The-OpenROAD-Project:master Nov 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants