Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/thealgorithms/maths/SmithNumber.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ private SmithNumber() {

private static int primeFactorDigitSum(int n) {
int sum = 0;
int num = n;

// Factorize the number using trial division
for (int i = 2; i * i <= num; i++) {
for (int i = 2; (long) i * i <= n; i++) {
while (n % i == 0) { // while i divides n
sum += SumOfDigits.sumOfDigits(i); // add sum of digits of factor
n /= i; // divide n by the factor
Expand All @@ -43,7 +42,7 @@ private static int primeFactorDigitSum(int n) {
* @return {@code true} if {@code number} is a Smith number, otherwise false
*/
public static boolean isSmithNumber(int number) {
if (PrimeCheck.isPrime(number)) {
if (number <= 3 || PrimeCheck.isPrime(number)) {
return false; // Smith numbers must be composite
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/thealgorithms/maths/SmithNumberTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
class SmithNumberTest {

@ParameterizedTest
@CsvSource({"4", "22", "121", "562", "985", "4937775"})
@CsvSource({"4", "22", "27", "58", "85", "94", "121", "562", "985", "4937775"})
void positiveSmithNumbersTest(int n) {
assertTrue(SmithNumber.isSmithNumber(n));
}

@ParameterizedTest
@CsvSource({"2", "11", "100", "550", "999", "1234557"})
@CsvSource({"-22", "-4", "-1", "0", "1", "2", "3", "5", "6", "8", "9", "10", "11", "100", "550", "999", "1234557"})
void negativeSmithNumbersTest(int n) {
assertFalse(SmithNumber.isSmithNumber(n));
}
Expand Down
Loading