refactor: improve bit manipulation helpers docs and validation#310
Open
Ashiish-Agarwal wants to merge 1 commit into
Open
refactor: improve bit manipulation helpers docs and validation#310Ashiish-Agarwal wants to merge 1 commit into
Ashiish-Agarwal wants to merge 1 commit into
Conversation
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the bit manipulation helpers in the
bit_manipulationmodule by:Changes
bit_manipulation/add_binary.ts0and1.parseIntexplicit.bit_manipulation/is_power_of_2.ts1is treated as a power of two).bit_manipulation/is_power_of_4.tsn % 3 === 1property.bit_manipulation/log_two.tsfloor(log2(n))for positive integers.RangeErrorforn <= 0instead of returning an incorrect value.Motivation
These changes make the functions safer to use and easier to understand, especially for people reading the code for learning purposes. The behavior for edge cases is now explicitly documented and enforced.