Skip to content

Fix: silent failures in host video controls #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeHeist-Coder merged 1 commit into from
Oct 28, 2026
Merged

Fix: silent failures in host video controls #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 43 additions & 20 deletions apps/frontend/src/components/live/LiveStage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ function Stage({ sessionId, isOrganizer, authToken, quizEnded }: StageProps) {
<HostAction
label="Mute all speakers"
onClick={() => muteAllSpeakers(sessionId, authToken)}
failureMessage="Couldn't mute all speakers."
>
Mute All
</HostAction>
Expand Down Expand Up @@ -396,7 +397,7 @@ function HostRowActions({ participant: p, sessionId, authToken }: { participant:
return (
<>
<MicState participant={p} />
<HostAction label={`Mute ${p.name}`} onClick={() => stopSpeaking(sessionId, authToken, participantId)}>
<HostAction label={`Mute ${p.name}`} onClick={() => stopSpeaking(sessionId, authToken, participantId)} failureMessage="Couldn't mute this participant.">
Mute
</HostAction>
</>
Expand All @@ -406,7 +407,7 @@ function HostRowActions({ participant: p, sessionId, authToken }: { participant:
return (
<>
{p.attributes.hand === 'up' && <FaHand className="shrink-0 text-amber-400" aria-label="Hand raised" />}
<HostAction label={`Let ${p.name} speak`} onClick={() => allowToSpeak(sessionId, authToken, participantId)}>
<HostAction label={`Let ${p.name} speak`} onClick={() => allowToSpeak(sessionId, authToken, participantId)} failureMessage="Couldn't allow this participant to speak.">
Let speak
</HostAction>
</>
Expand Down Expand Up @@ -439,27 +440,49 @@ function PlayerRow({ participant, children }: { participant: Participant; childr
}

/** A host's button on one player's row; `label` names the player for screen readers. */
function HostAction({ label, onClick, children }: { label: string; onClick: () => Promise<void>; children: ReactNode }) {
function HostAction({
label,
onClick,
children,
failureMessage,
}: {
label: string;
onClick: () => Promise<void>;
children: ReactNode;
failureMessage: string;
}) {
const [busy, setBusy] = useState(false);
const [problem, setProblem] = useState<string | null>(null);

return (
<button
aria-label={label}
disabled={busy}
onClick={async () => {
setBusy(true);
try {
await onClick();
} catch (err) {
console.error('[live] host action failed', err);
} finally {
setBusy(false);
}
}}
className="shrink-0 px-2 py-0.5 rounded-md border border-pink-600/50 text-pink-300 hover:bg-pink-600/20 text-[11px] sm:text-xs cursor-pointer disabled:opacity-50"
>
{children}
</button>
<span className="inline-flex flex-wrap items-center gap-2">
<button
aria-label={label}
disabled={busy}
onClick={async () => {
setBusy(true);
setProblem(null);

try {
await onClick();
} catch (err) {
console.error("[live] host action failed", err);
setProblem(streamError(err, failureMessage));
} finally {
setBusy(false);
}
}}
className="shrink-0 px-2 py-0.5 rounded-md border border-pink-600/50 text-pink-300 hover:bg-pink-600/20 text-[11px] sm:text-xs cursor-pointer disabled:opacity-50"
>
{children}
</button>

{problem && (
<span role="alert" className="text-[11px] text-rose-300">
{problem}
</span>
)}
</span>
);
}

Expand Down
Loading