feat: implement multi transport types for the same dataset by diogodanielsoaresferreira · Pull Request #2579 · TimefoldAI/timefold-solver

diogodanielsoaresferreira · 2026-08-10T17:32:47Z

Allow to solve routing problems with more than one transportType.

Created additional properties in Location so that we keep the hot path without the Map access.

Related with https://github.com/TimefoldAI/timefold-platform/issues/2690

sonarqubecloud · 2026-08-10T17:54:58Z

Quality Gate failed

Failed conditions
31.1% Coverage on New Code (required ≥ 70%)

Add a TransportType value type and per-mode travel-time/distance matrices on Location, so the same routing problem can use more than one transport profile (e.g. car + bike). The default CAR mode keeps the existing scalar/ timeframe fields and index-cache fast path; extra modes are stored in opt-in maps that stay null for single-mode problems. The TravelTimeMatrixEnricher fetches one matrix set per transport type (each resolving to its own OSRM instance), and map-service.transport-type now accepts a comma-separated list of modes (first entry is primary). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Resolved conflicts in TravelTimeMatrixEnricher and LocationsAwareSolverModel: keep the per-transport-type enrichment and getTransportTypes(), and take main's null check on the locations and the default getLocationSetName(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

…mething that the model builder can configure

rsynek · 2026-10-13T11:28:14Z

There seem to be formatting issues; could you please have a look @diogodanielsoaresferreira ?

rsynek

Thanks for addressing all the comments!

rsynek · 2026-10-13T15:22:19Z

I think the downstream build fails as the branch name does not match, is that correct @diogodanielsoaresferreira ?

@winklerm Looking at FSR, it uses the MapServiceOptionsSupplier (an impl class, not a part of the API) in the validator.

winklerm · 2026-10-14T06:12:09Z

I think the downstream build fails as the branch name does not match, is that correct @diogodanielsoaresferreira ?

@winklerm Looking at FSR, it uses the MapServiceOptionsSupplier (an impl class, not a part of the API) in the validator.

@rsynek @diogodanielsoaresferreira Very good catch! Looking at it now, it seems to me we should add it into the API package, or provide another way in the API to construct the MapService with parameters respecting map service configuration. Having said that, this problem was already there before this PR, so up to you if you want to address it here or send another PR for that.

The build passes locally, but I need to double check if the new Location API variants with transport type are called in all new places meanwhile merged to main. Update: checked and it seems all good at the moment.

winklerm

Thank you, looks good to me!

I have left one question inline.

Other than that, it would be nice to resolve MapServiceOptionsSupplier being unavailable in the public API, see Radek's comment, but fine to leave that out of scope because it was not introduced by these changes.

winklerm · 2026-10-14T06:36:15Z

+        List<TransportType> datasetTransportTypes = solverModel.getTransportTypes().stream()
+                .filter(Objects::nonNull)
+                .distinct()
+                .sorted() // Deterministic order; CAR, when used, comes first and is therefore the primary one.


Q: Looks a bit fragile to me - if we add a new transport type BOAT, will it become primary?

TLDR added a comparator to make car always first.

To be clear on what this does, the first transport type is used as primary, which means:

if a request to the location is done without specifying the transport type, it will use that one as default

that map is used to check the locations out of map.

I don't think it's that much of a deal to not have car first, but I think that it's a nice improvement, taking into account that maps with CAR are the ones usually running, so we can check if there is any location out of the map faster.

I updated to add a comparator and make the default transport type more visible

rsynek · 2026-10-14T07:59:50Z

@diogodanielsoaresferreira today is a cut-off for the solver release and this PR is in my opinion close to merging.

I would take the MapServiceOptionsSupplier out of the scope, as it has been already introduced before.

Could you please respond to Marek's other comment and rebase the PR on top of main?

diogodanielsoaresferreira · 2026-10-14T10:26:07Z

@diogodanielsoaresferreira today is a cut-off for the solver release and this PR is in my opinion close to merging.

I would take the MapServiceOptionsSupplier out of the scope, as it has been already introduced before.

Could you please respond to Marek's other comment and rebase the PR on top of main?

Done ✅ I agree with taking the MapServiceOptionsSupplier out of the scope. I also created a branch with the same name in FSR so that the tests can run (and they are 🟢 ).

winklerm

Thank you, looks good!

diogodanielsoaresferreira requested review from cristianonicolai, mswiderski and winklerm August 10, 2026 17:32

diogodanielsoaresferreira temporarily deployed to internal August 10, 2026 17:32 — with GitHub Actions Inactive

diogodanielsoaresferreira temporarily deployed to internal August 24, 2026 11:02 — with GitHub Actions Inactive

diogodanielsoaresferreira and others added 2 commits September 4, 2026 07:45

feat: remove comments

862e09d

winklerm force-pushed the draft/transport-type-aware-location branch from ea51de8 to 862e09d Compare September 4, 2026 05:46

winklerm temporarily deployed to internal September 4, 2026 05:46 — with GitHub Actions Inactive

chore: change TransportType to enum to quick fix OpenAPI spec

9173ac6

winklerm temporarily deployed to internal September 4, 2026 09:32 — with GitHub Actions Inactive

feat: add Transport types and replace map of distance matrixes by array

0f53d1a

diogodanielsoaresferreira temporarily deployed to internal September 10, 2026 15:12 — with GitHub Actions Inactive

feat: remove options from argument in MapsServiceOptionsSupplier

829157e

diogodanielsoaresferreira temporarily deployed to internal September 10, 2026 15:29 — with GitHub Actions Inactive

diogodanielsoaresferreira deployed to internal September 10, 2026 15:29 — with GitHub Actions Active

Merge branch 'main' into draft/transport-type-aware-location

772ab5e

diogodanielsoaresferreira deployed to internal September 16, 2026 09:09 — with GitHub Actions Active

Update transport types

2a66083

diogodanielsoaresferreira deployed to internal September 16, 2026 12:23 — with GitHub Actions Active

feat: add allowed transport type to maps service client

a5f4a27

diogodanielsoaresferreira deployed to internal September 21, 2026 15:22 — with GitHub Actions Active

diogodanielsoaresferreira deployed to internal October 12, 2026 14:42 — with GitHub Actions Active

diogodanielsoaresferreira deployed to documentation (preview) October 12, 2026 14:42 — with GitHub Actions

View deployment

fix: add tests to location class

3677396

diogodanielsoaresferreira deployed to internal October 12, 2026 15:08 — with GitHub Actions Active

diogodanielsoaresferreira deployed to documentation (preview) October 12, 2026 15:08 — with GitHub Actions

View deployment

diogodanielsoaresferreira requested a review from rsynek October 12, 2026 15:09

diogodanielsoaresferreira and others added 2 commits October 12, 2026 17:11

fix: add tests to location class

0a35c94

diogodanielsoaresferreira deployed to internal October 12, 2026 15:12 — with GitHub Actions Active

diogodanielsoaresferreira added 2 commits October 12, 2026 17:27

fix: apply style changes

4c19293

fix: remove auto-select from model enrichment docs, since it's not so…

9f01eb7

…mething that the model builder can configure

fix: apply style changes

9bce706

rsynek approved these changes Oct 13, 2026

View reviewed changes

winklerm reviewed Oct 14, 2026

View reviewed changes

diogodanielsoaresferreira added 3 commits October 14, 2026 12:20

fix: sort with car being the first when resolving transport types

7ab95da

fix: sort with car being the first when resolving transport types

8baba9a

Merge branch 'main' into draft/transport-type-aware-location

fd8b482

winklerm approved these changes Oct 14, 2026

View reviewed changes

timefold-automations Bot mentioned this pull request Oct 14, 2026

docs: [docs-drift] draft/transport-type-aware-location #2753

Open

Navigation Menu

Repository navigation

feat: implement multi transport types for the same dataset - #2579

feat: implement multi transport types for the same dataset#2579
triceo merged 28 commits into
mainfrom
draft/transport-type-aware-location

diogodanielsoaresferreira commented Aug 10, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Aug 10, 2026

Uh oh!

rsynek commented Oct 13, 2026

Uh oh!

rsynek left a comment

Uh oh!

rsynek commented Oct 13, 2026

Uh oh!

winklerm commented Oct 14, 2026 •

edited

Loading

Uh oh!

winklerm left a comment

Uh oh!

winklerm Oct 14, 2026

Uh oh!

diogodanielsoaresferreira Oct 14, 2026 •

edited

Loading

Uh oh!

rsynek commented Oct 14, 2026

Uh oh!

diogodanielsoaresferreira commented Oct 14, 2026

Uh oh!

winklerm left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

diogodanielsoaresferreira commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Aug 10, 2026

Quality Gate failed

Uh oh!

rsynek commented Oct 13, 2026

Uh oh!

rsynek left a comment

Choose a reason for hiding this comment

Uh oh!

rsynek commented Oct 13, 2026

Uh oh!

winklerm commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

winklerm left a comment

Choose a reason for hiding this comment

Uh oh!

winklerm Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

diogodanielsoaresferreira Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsynek commented Oct 14, 2026

Uh oh!

diogodanielsoaresferreira commented Oct 14, 2026

Uh oh!

winklerm left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

diogodanielsoaresferreira commented Aug 10, 2026 •

edited

Loading

winklerm commented Oct 14, 2026 •

edited

Loading

diogodanielsoaresferreira Oct 14, 2026 •

edited

Loading