You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated references to 'map service' to 'maps extension' for clarity. Modified fallback behavior description and corrected method calls for travel time retrieval.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Being present in the map does not guarantee reachability because two valid locations can belong to disconnected road components, so the text must not imply that checking locationsNotInMap eliminates every UNREACHABLE result.
This introduces the deprecated getDrivingTimeTo(...) alias even though Location marks it @Deprecated at service/maps/api/src/main/java/ai/timefold/solver/service/maps/api/model/Location.java:174-176, so use getTravelTimeTo(...) consistently.
This issue also appears in the following locations of the same file:
line 176
line 354
Clarify UniqueLocationAccumulator does not canonicalize locations
UniqueLocationAccumulator only detects equal-but-distinct instances and does not canonicalize model references, so presenting it as a way to share one Location can leave omitted instances without an injected matrix.
Distinguish TravelTimeMatrixEnricher from remote map service
TravelTimeMatrixEnricher is the built-in enricher while the map service is its optional remote backend, so calling the map service itself the enricher conflates the two concepts and contradicts the local Haversine path.
Document departure-time overload for traffic-enabled lookups
When traffic is enabled the scalar lookup reads only the first available timeframe (Location.java:99-108), so this configuration entry must direct users to the departure-time overload or the documented examples will silently ignore the other matrices.
Handle location set name when enriching traffic timeframes
This claim is not true when use-traffic=true because TravelTimeMatrixEnricher.enrichAllTimeframes() calls optionsSupplier.getOptions() without solverModel.getLocationSetName(), so either propagate the name in that path or document the limitation.
Locations on disconnected road networks can all be in the map while routes between them remain unreachable, so replace this guarantee with advice to check route reachability even when getLocationsNotInMap() is empty to avoid exceptions during scoring.
The standard service parent includes timefold-solver-service without maps integration, so add the ai.timefold.solver:timefold-solver-service-with-maps dependency before this example to make the maps types and automatic enricher available.
With traffic enabled, the one-argument lookups shown above use the first available timeframe rather than the trip's departure time, so document the departure-time overloads here to prevent scoring trips against the wrong traffic matrix.
With use-traffic=true, TravelTimeMatrixEnricher.enrichAllTimeframes() omits the model's location-set name from the request, so qualify this section to explain that traffic mode requests per-timeframe matrices instead of reusing the named set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions
Failure
@rsynek, need your help pulling this over the finish line.