Repository navigation
Conversation
rsynek
commented
Oct 13, 2026
| /** | ||
| * Produces StorageObjectMapper instances with storage-specific (de)serialization settings. | ||
| */ | ||
| @ApplicationScoped |
Contributor
Author
There was a problem hiding this comment.
This again breaks the rule about no beans in the definition model. However, it was there silently, as it contains the Producer annotation and CDI pick it up if there are other beans in the module.
Removing this bean will be a subject of additional refactoring of AbstractStorageService.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The relocated parameter type breaks a public API constructor despite the compatibility suppression.
1 open finding
What changed in this PR
Moves map enrichment CDI ownership from service definition to the maps client.
Changes:
- Relocates
MapEnrichmentContext. - Adds a maps-client producer and optional worker fallback.
- Updates imports, tests, and compatibility metadata.
| File | Description |
|---|---|
SolverWorker.java |
Resolves the context optionally. |
TravelTimeMatrixEnricherTrafficTest.java |
Updates the context import. |
TravelTimeMatrixEnricherTest.java |
Updates the injected context import. |
MapEnrichmentContextProducer.java |
Produces the maps-client CDI bean. |
TravelTimeMatrixEnricher.java |
Uses the relocated context. |
revapi-differences.json |
Suppresses the constructor API break. |
definition/internal/MapEnrichmentContext.java |
Removes the old context class. |
StorageObjectMapperProducer.java |
Adds an explicit CDI scope. |
definition/impl/enrichment/MapEnrichmentContext.java |
Adds the relocated non-bean context. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rsynek
force-pushed
the
chore/map-enrichment-context
branch
from
October 14, 2026 12:01
72eaf53 to
501349d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
MapEnrichmentContextbean from the definition module, which should stay safe to depend on with no side effect. Also, places the class into a more fitting package.