Skip to content

docs: update partitioned search docs - #2748

Merged
triceo merged 3 commits into
TimefoldAI:mainfrom
zepfred:doc/ps
Oct 14, 2026
Merged

triceo merged 3 commits into
TimefoldAI:mainfrom
zepfred:doc/ps

Conversation

@zepfred

@zepfred zepfred commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused documentation update is clear, useful, and follows repository formatting conventions.

0 open findings

What changed in this PR

Documents important Partitioned Search restrictions for list-variable models.

Changes:

  • Requires an uninitialized initial solution.
  • Prohibits shared planning entities or values across partitions.
File Description
docs/​src/​modules/​ROOT/​pages/​running-timefold-solver/​multithreaded-solving.adoc Adds a warning about list-variable partitioning requirements.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/src/modules/ROOT/pages/running-timefold-solver/multithreaded-solving.adoc Outdated
@zepfred
zepfred marked this pull request as draft October 13, 2026 18:37
@zepfred

zepfred commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Putting it on draft because I'm investigating a possible issue with the PS logic.

@zepfred
zepfred marked this pull request as ready for review October 14, 2026 17:56
Copilot AI balanced review requested due to automatic review settings October 14, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The guidance is ambiguous for supported mixed-variable models.

1 open finding

🧠 Review effort: Balanced

Comment thread docs/src/modules/ROOT/pages/running-timefold-solver/multithreaded-solving.adoc Outdated
Clarified partitioning requirements for planning entities and values in variable models.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 14, 2026 18:00
@triceo triceo changed the title chore: update partitioned search docs docs: update partitioned search docs Oct 14, 2026
@triceo
triceo merged commit 574affa into TimefoldAI:main Oct 14, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately clarifies existing partitioning requirements.

0 open findings

1 resolved since last review

🧠 Review effort: Balanced

@zepfred
zepfred deleted the doc/ps branch October 14, 2026 18:06

This branch was successfully deployed

2 active deployments
documentation (preview) — 150dba71 Deployed Oct 14, 2026 by zepfred via Build Documentation #792
internal — 150dba71 Deployed Oct 14, 2026 by zepfred via approval_required #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants