Repository navigation
docs: [docs-drift] chore/incrementalize-vehicle-routing - #2751
Open
timefold-automations[bot] wants to merge 1 commit into
Open
timefold-automations[bot] wants to merge 1 commit into
timefold-automations[bot] wants to merge 1 commit into
Conversation
timefold-automations
Bot
requested review from
TomCools,
rsynek and
triceo
as code owners
October 14, 2026 07:13
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged group: TimefoldAI/timefold-quickstarts#1218 by TomCools.
Findings
High confidence — fixed: The merged quickstart change replaced the route-total loops in
use-cases/vehicle-routing/src/main/java/org/acme/vehiclerouting/domain/Vehicle.java:74-98with cumulative shadow-variable access. The copied documentation indocs/src/modules/ROOT/pages/quickstart/quarkus-vehicle-routing/vehicle-routing-model.adoc:153-172still used the removed loops. Updated the JavaVehiclesample to use the last visit's cumulative demand and driving time, including the uninitialized-shadow fallback.High confidence — remaining: The merged quickstart change added
cumulativeDemand,cumulativeDemandSupplier(),getCumulativeDrivingTimeSeconds(), and the cumulative-driving-time component ofTimingsinuse-cases/vehicle-routing/src/main/java/org/acme/vehiclerouting/domain/Visit.java:34-137and itsTimingsrecord. The copied JavaVisitsample atdocs/src/modules/ROOT/pages/quickstart/quarkus-vehicle-routing/vehicle-routing-model.adoc:300-386has no mention of these additions. I did not rewrite this block because it already uses an older, different Visit model and annotations; adding only the new members would leave an internally inconsistent sample. This remains for a separate synchronization of that pre-existing model drift.The group is already merged, so this pull request fixes
main. It should be updated if more pull requests onchore/incrementalize-vehicle-routingmerge.