Remove the three unbuildable crates - #893
Merged
Merged
Conversation
`advent_of_code_2017`, `tpchlike` and `doop` are commented out of `workspace.members` and are not in `workspace.exclude` either, so they cannot be built by any route — a standalone `cargo check` fails with "current package believes it's in a workspace when it's not". They have missed the last several API migrations. `experiments`, `diagnostics` and `dogsdogsdogs` were updated for timely #817-#819 in \#877; these three were not, and were last touched in #724 (April) and \#673 (February). Nothing outside their own trees references them beyond the three commented `members` lines removed here. 13,294 lines, ~21% of the repository's Rust. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
frankmcsherry
added a commit
to frankmcsherry/differential-dataflow
that referenced
this pull request
Sep 22, 2026
CHUNK-ORDNEU.md has been living loose in ~/Projects, outside any repository, while being the only document that explains what this branch is, what it measured, and what integrating it would mean. Move it in beside the code it describes, following the repo's existing co-located-note convention (formal/DESIGN.md, interactive/examples/aoc2023/GAPS.md). Refreshed for the rebase onto TimelyDataflow#893 and the perf commit: §2 is now an ord_neu vs CHUNK matrix over three `spines` batch sizes and three default-flip workloads (bfs at two scales, scc), which separates what the harness costs from what the trie layout earns; §5 records that `tpchlike` -- the run earlier drafts named as the missing verdict -- was deleted in TimelyDataflow#893, and that the Cargo.lock gotcha now points the other way (the branch needs current timely, not the older pin). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
advent_of_code_2017,tpchlikeanddoopare commented out ofworkspace.membersand are not inworkspace.excludeeither, so they cannot be built by any route. A standalone check fails outright:They have missed the last several API migrations —
experiments,diagnosticsanddogsdogsdogswere updated for timely #817–#819 in #877, these three were not. Last touched in #724 (April,tpchlikeandadvent_of_code_2017) and #673 (February,doop).Nothing outside their own trees references them beyond the three commented
memberslines removed here.cargo check --workspace --all-targetspasses after the removal.13,294 lines, about 21% of the repository's Rust.
🤖 Generated with Claude Code