Repository navigation
fix(frontend): let drag handle icons start a drag - #1999
Merged
smartcmd merged 1 commit intoOct 30, 2026
Merged
Conversation
Pressing the animated icon inside a sortable item starts no native drag in Chromium. The icon's SVG takes focus on mousedown, useIconAnimation moves that focus away, and the browser never fires dragstart for the row underneath. That left the group sort dialog unable to move a row when grabbed on its menu icon, and the payment provider list unable to move a provider at all, because its only handle is the grip icon. Marking both icons pointer-events-none keeps the press on the row or handle, so the whole handle area drags again. Record the rule in the icon conventions.
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Type of change
Description
Dragging a row by its
≡handle did nothing in the group sort dialog, while dragging by the row text worked. The animated icon is the cause: pressing it focuses the SVG,useIconAnimationmoves that focus away, and Chromium then never starts the native drag thatvue-draggable-plusrelies on. The payment provider list was worse, because its only handle is the grip icon, so that list could not be reordered at all.Both icons are now
pointer-events-none, which keeps the press on the row or the handle. Appearance is unchanged.The change and this description were produced by an AI coding agent (OpenCode, model
magpie/auto/deepseek-v4.1-flash) at the owner's request. A second agent (Codex, modelgpt-6-astra) independently reviewed the diagnosis and the scope of the fix.Proof of Work
A repro page mounted the real
Icon.vueand the realvue-draggable-plusunder the project's Tailwind build, driven in Chrome through ego-browser. The list items carry placeholder names here; the actual deployments use their own group and provider names.Before the fix:
≡icon: nodragstartevent fired, order unchanged (3/3 runs).#idtext: worked.handle=".drag-handle": dragging its grip icon left the order unchanged (provider-a,provider-b,provider-c).After the fix:
≡handle area:group-a,group-b,group-cbecamegroup-b,group-c,group-a.provider-a,provider-b,provider-cbecameprovider-b,provider-c,provider-a.Checks run in
frontend/:npm run typecheck(no output, exit 0),npx prettier --checkon both components,npm run check:comments(1288 files, 0 violations),npx vitest run GroupsView.tabs GroupsView.duplicate(34 passed),npx vitest run SettingsView(57 passed). From the repository root:make fmt,make fmt-check(Prettier reports all files formatted).No screenshot is attached because the change alters hit testing only and the dialog renders the same. No automated test was added: the defect only appears with real Chromium native drag, and jsdom does not reproduce it.
Checklist