Repository navigation
Show a persistent notice when Research disables tracker blocking - #992
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Research mode (
log_logcat=true) disables tracker blocking, even when Strict mode and saved blocking rules are selected. In #968, this made the allowed-connection statistics appear to contradict the configured “Blocked” labels. The existing short toast was easy to miss.Show a persistent notice above the Timeline, Apps, and VPN tabs while
log_logcatis enabled: “Research mode is on. Tracker blocking is disabled. Tap to change settings.” Tapping opens Settings. The notice updates when the preference changes and disappears when Research is disabled. The Research preference description now explicitly states that blocking is disabled.The notice follows
log_logcat, independently ofsni_enabled: enabling SNI alone does not show it, and imported settings with Research enabled but SNI disabled still do. Tracker-blocking behaviour is unchanged.Validation:
This is a standalone UI change based on current master; it does not depend on #982.