Add Jacobian lens (J-lens): published-artifact loading, readout, native fitting, and interventions#1507
Conversation
jlarson4
left a comment
There was a problem hiding this comment.
Hi @danielxmed! Thanks for putting this together, finally getting around to a full review for you. This is a very comprehensive review with a lot of comments, apologies in advance. For something like this I want to be extra thorough. Please let me know if you run into any questions as you work through them
I have a couple general suggestions that don't tie to any specific line:
- gemma parity test: #1505 committed to slow
gemma-2-2bparity tests and itself noted the CI-cached-itvariant has a published lens. A@pytest.mark.slow gemma-2-2b-itparity test is feasible and would give thesoftcappath and a second architecture CI coverage. - I noted in the $1505 that we should drop support for
HookedTransformerfrom this tool. Please do that, and then begin making your way through my comments. Some of them may be obsoleted by dropping that support, ping me if you are uncertain at any point.
|
|
||
| .. math:: | ||
|
|
||
| J_\\ell = \\mathbb{E}_{\\text{prompt},\\,t,\\,t' \\geq t} |
There was a problem hiding this comment.
The header formula is a mean over (prompt, t, t' >= t) triples, but the implementation takes the sum over targets and averages only over sources and prompts (~56× difference at seq 128, skip 16). Anyone calibrating raw J magnitudes from this formula will be misled; the header is the only dissenter, so fix it here.
| f"layer {layer} is not in this lens's source layers " | ||
| f"({self.source_layers[0]}..{self.source_layers[-1]})" | ||
| ) | ||
| unembed_columns = model.W_U[:, token_ids].float() # [d_model, n] |
There was a problem hiding this comment.
lens_vectors reads model.W_U with no validate_model(model). It's the gateway for steering_hooks/ablation_hooks/swap_hooks, so all three build and run on a fold_ln+center_unembed HT (or compat-mode Bridge; the hook names still resolve) while computing vectors in the wrong residual basis. That's the silent-wrongness L34–37 promises to refuse loudly, and #1505's plan validated on attach, the per-call model API change dropped that invariant. One validate_model(model) here restores it for all three builders.
| } | ||
| if self.metadata: | ||
| payload["metadata"] = self.metadata | ||
| torch.save(payload, path) |
There was a problem hiding this comment.
save() stores arbitrary metadata, but load() (L213) uses weights_only=True. A numpy scalar in metadata saves fine and then fails this module's own load() with an opaque UnpicklingError, before the friendly no-'J'-key error is reached. Consider validating metadata values are weights-only-safe primitives at save time.
| else: | ||
| from huggingface_hub import hf_hub_download | ||
|
|
||
| local_path = hf_hub_download(name_or_path, filename, revision=revision) |
There was a problem hiding this comment.
Two robustness gaps:
hf_hub_downloadhere isn't wrapped bycall_hf_with_retry, so lens downloads lack the 429 backoff every other Hub fetch in the repo gets.revision=Nonetracks the mutable main of a third-party repo. Wrap the call, and consider documenting revision-pinning in the docstring.
| raise ValueError( | ||
| "all lenses being merged must share the same source_layers and d_model" | ||
| ) | ||
| total = sum(lens.n_prompts for lens in lenses) |
There was a problem hiding this comment.
load() defaults a missing n_prompts to 0 (L221) and this weighting multiplies that shard by zero. Raise or warn when any merged lens has n_prompts == 0.
| # raw checkpoints sit orders of magnitude above the 0.01 threshold | ||
| # (measured: gpt2 3.4, gemma-2-2b 17.2; centered gpt2 ~1e-7). | ||
| rows = unembed_weight[:64].float() | ||
| if rows.mean(dim=-1).abs().max() < 0.01 * rows.abs().mean(): |
There was a problem hiding this comment.
With this threshold, random-init W_U trips the guard in 20/20 seeds at d_vocab=256k (0/20 at GPT-2's 50k). Random row means scale as ~1/sqrt(d_vocab) and cross 0.01 right around Gemma/Llama-3 vocabs, so fitting on an untrained control model (a standard interp baseline) errors out claiming center_unembed. Your own measurement on L836 (centered ≈ 1e-7 vs trained ≥ 3.4) supports a much tighter threshold with ~10^4 margin both ways:
if rows.mean(dim=-1).abs().max() < 1e-3 * rows.abs().mean():
| jacobians = { | ||
| layer: torch.zeros(d_model, d_model, dtype=torch.float32) for layer in source_layers | ||
| } | ||
| cotangent = torch.zeros_like(target) |
There was a problem hiding this comment.
zeros_like(target) makes the cotangent run in the model dtype. fp32 begins only at the post-hoc .float() on L971. For bf16 models that's ~8-bit-mantissa accumulation with no test pinning it and no recorded fit dtype. At minimum record the dtype in metadata and recommend fp32 fits in the docstring, upcasting the captured activations would fix it outright.
| """ | ||
| compute_dtype = model.W_U.dtype | ||
| batched = residual.to(device=model.W_U.device, dtype=compute_dtype).unsqueeze(0) | ||
| logits = model.unembed(model.ln_final(batched)).float().squeeze(0) |
There was a problem hiding this comment.
This line assumes every validated model owns an ln_final module, but the two ends of the chain disagree: _require_unprocessed_weights normalizes normalization_type=None to "" (see L812), so None-norm models pass the fold_ln check, While HookedTransformer.__init__ explicitly skips creating ln_final when normalization_type is None (see HookedTransformer.py:247-249). nn.Module.__getattr__ then raises on the missing submodule. The failure ordering is what we're aiming to fix here: fit() never unembeds anything, so it validates and completes, the crash waits for the first readout.
model = HookedTransformer(HookedTransformerConfig(..., normalization_type=None)) # attn-only toy
lens = JacobianLens.fit(model, prompts) # validator passes; full fit succeeds
lens.readout(model, prompt) # AttributeError: 'HookedTransformer' object has no attribute 'ln_final'
The user pays the whole fitting cost, then gets a bare AttributeError from deep inside _unembed that names neither normalization nor the lens contract.
Two possible solutions:
- Reject
normalization_type in (None, "")in_require_unprocessed_weightswith an actionable message. This option is loudest, though it also bansfit, which works fine on these models - Mirror the model's own forward semantics:
final = model.ln_final(batched) if getattr(model, "ln_final", None) is not None else batched. Two lines that keep attn-only toy models fully supported and unembed them exactly the wayHookedTransformeritself does.
|
|
||
|
|
||
| @pytest.fixture(scope="module") | ||
| def published_lens(ht_gpt2): |
There was a problem hiding this comment.
This fixture is only consumed by the readout-agreement test. fit() and all three intervention builders never execute on a real Bridge in CI, and those are exactly the code paths the module-side comments flag. One small Bridge fit-or-steering test here would cover them.
| nn.init.normal_(self.linear.weight, std=0.2) | ||
| self.hook_resid_post = HookPoint() | ||
|
|
||
| def forward(self, resid): |
There was a problem hiding this comment.
With per-position Linear blocks there's no cross-position interaction, so only the t' == t term is nonzero. A deliberately wrong fit planting cotangents at ALL positions passes the closed-form test bit-for-bit. The integration tests are cosine-based or fit-vs-fit, so nothing pins the target set. One toy variant with attention-style mixing closes the hole.
…nterventions Implements the Jacobian lens (Gurnee et al., Transformer Circuits 2026) as a tools/analysis component working with both TransformerBridge (raw weights) and HookedTransformer (from_pretrained_no_processing): - load/save in the official anthropics/jacobian-lens artifact format (fp16 storage, fp32 in memory), including artifacts published on the HF Hub - per-layer readout through the model\x27s own final norm, unembed, and logit soft cap, with the logit lens as the J=I baseline in the same code path - native fitting reproducing the reference estimator (one-hot cotangents at all valid target positions, sum over targets / mean over sources / mean over prompts), plus n_prompts-weighted merge() for parallel fitting - interventions from the paper: steering, ablation, pseudoinverse coordinate swap in lens coordinates - loud guards refusing fold_ln/compatibility-mode models (the published lenses are fitted on raw HF activations) Unit tests pin the estimator to a closed-form linear toy model. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Covers Hub artifact loading/validation, the final-row identity, the rank-collapse late-layer invariant, logit-lens divergence mid-stack, HookedTransformer/TransformerBridge raw-basis agreement, a directional steering smoke test, processed-model refusal, the exact fit==merge identity, and small-fit convergence toward the published lens (cosine 0.91 at L10 from 2 prompts). Fixes _unembed to respect the [batch, pos, d_model] component contract under runtime type checking. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gemma-2-2b via raw TransformerBridge + the published Hub lens: J-lens vs logit-lens readout on a two-hop prompt with an unspoken intermediate (boot -> Italy -> euro), rank-trajectory plot for pinned tokens, the France->China pseudoinverse coordinate swap (top-1 flip on the language template at alpha=1; Beijing rank 968 -> 8 on the capital template), and J-lens steering. Outputs are baked; verified with nbval locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nance wording - Detect center_unembed processing via the exactly-mean-centered W_U signature: from_pretrained(fold_ln=False) keeps normalization_type LN while still centering weights, which the fold_ln marker alone missed (lens vectors on such a model are silently wrong; readout ranks survive only because LN absorbs the centered component). - Bounds-check readout layers on the logit-lens path and positions after normalization (out-of-range values previously crashed with a raw KeyError or wrapped silently). - Steering: scale by the median per-position residual norm instead of the mean (attention-sink positions run orders of magnitude hot and made the effective strength prompt-length dependent), and attribute the norm-matched parameterization to the reference implementation experiments, not the paper (whose minimal form is h += alpha*v_t). - Move readout residuals to the unembedding device for sharded models; document merge() metadata handling; reword docstrings/error strings that tracked the reference implementation too closely. - Demo notebook: kernelspec metadata, honest alpha=2 overshoot phrasing (the paper reports alpha=2 recovering failures; gemma-2-2b overshoots), measured-GPU wording; re-executed, nbval clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
39a97fd to
2777016
Compare
|
Thanks for the thorough review. I reworked the PR around a strict TransformerBridge-only contract and addressed all inline points.
Final validation is clean: |
Description
Implements the Jacobian lens (J-lens) as a TransformerBridge-only analysis component, following the design proposal in #1505 and the estimator from Gurnee et al., Verbalizable Representations Form a Global Workspace in Language Models.
The J-lens characterizes an intermediate residual activation by its corpus-averaged first-order causal effect on the final residual stream. Each fitted source layer has one
d_model × d_modeltransport matrix; readout then uses the model's own final norm, unembedding, and architecture-specific output-logit transform. The logit lens is available through the same path by disabling Jacobian transport.Fixes #1505.
What is included
JacobianLens.from_pretrained,load, andsave, compatible with the publishedneuronpedia/jacobian-lensartifact format. TransformerLens artifacts may add recursively validated provenance metadata while remaining loadable withweights_only=True.readout, returning retained top-k values and token ids by default, with full vocabulary logits available as an explicit opt-in. The final layer reuses the model's actual logits rather than recomputing them.t' >= t, averages valid source positions per prompt, then averages prompts equally.mergecombines disjoint prompt shards using positiven_promptsweights and requires matching provenance.steering_hooks,ablation_hooks, and pseudoinverse-coordinateswap_hooks, with shared position, shape, dtype, and device validation.demos/Jacobian_Lens_Demo.ipynb.Supported model contract
JacobianLens requires a freshly booted, raw-weight, causal decoder-only
TransformerBridgewith a single rank-3 residual stream per block and a direct final-norm/unembedding path.HookedTransformer, compatibility mode, manually processed weights, encoder/seq2seq models, recurrent physical-block reuse, multi-stream block outputs, and unsupported final projections are rejected explicitly before fitting or readout.Output-logit behavior is delegated to architecture adapters. This PR adds explicit contracts for Cohere/Cohere2 scaling, Granite division by
logits_scaling, Falcon-H1 multiplication bylm_head_multiplier, Gemma-family softcaps, and fail-closed handling for ambiguous MPTlogit_scaleconfigurations.Review-driven changes
target_layerpath.google/gemma-2-2b-itpublished-artifact parity test covering top-k and softcapping.Type of change
Validation
All results below were produced from the final reviewed tree on local WSL/Ubuntu with the local RTX GPU where applicable:
make test-pr: 3,521 unit, 18 docstring, 150 acceptance, and 856 integration tests passed.nbval.make check-format: 640 files clean.uv run mypy .: 317 source files clean.uv build: sdist and wheel built successfully.git diff --checkand a secret-pattern scan passed.Checklist