Conversation
Collaborator
|
Looks good, thanks @emerardd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require
attribution_patch()to run with the model and every submodule in evaluation mode, preventing separate clean and corrupt forwards from mixing independent dropout realizations into false causal effects.This extracts the all-submodule state validation already used by
JacobianLens.fit()into a shared private helper. The helper also inspects a Bridge's deliberately unregisteredoriginal_model, reports the offending module paths, and rejects invalid state without mutating caller-owned training flags. Input-shape validation still runs first, while the state guard runs before either attribution forward.Regression coverage includes root training mode, an eval root with only a nested dropout in training mode, hidden
original_modelstate, preservation of training flags, and exact-zero attribution for identical inputs in evaluation mode.Fixes #1787
Type of change
Checklist:
142 passed)Local validation