Repository navigation
feat: preserve pretrained lens provenance and add filtered readouts - #2014
Merged
Merged
Conversation
Collaborator
|
Looks good, merging as is! |
Closed
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve provenance when loading converted pretrained J++ lenses and add optional filtered vocabulary readouts to
JacobianLens, following the scope approved in #1991.metadata["provenance"]across save/load, without adding model-name constraints or new merge rules.exclude_token_idstoreadout(), applied before lens top-k and recorded on the result. Full logits and model top-k remain unchanged; the same filtering works for logit-lens and final-layer readouts.readout_token_exclusions()inutilities/tokenize_utils.py, with Unicode-aware decoding, padded output-vocabulary coverage and explicit retained ids.Fixes #1991
Type of change
Validation
mypy .: 391 source files passed.The full PR-review test invocation was attempted offline but stopped during collection because the SoLU model dependencies were not cached. Running the wider JacobianLens integration surface also exposed missing GPT-2 weights and published lens artifacts (218 passed, 2 failed and 12 setup errors, all resource-loading failures). These runs are not reported as passing; full-suite verification remains for CI.
Checklist