refactor(preview): extract the browser lifecycle behind an internal seam - #265
Merged
Conversation
preview_panel/lifecycle.rs owns the session-keyed slot map, platform
creation, visibility, warmth, draft-key migration, pruning, and
teardown behind ensure/navigate/set_visible/drop_view/prune with
Availability{Ready,Starting,Unavailable}; the two ordering facts
(hide-before-unmount, warm-before-value-ops) are documented on the
interface. The macOS-sync and Windows-async creation paths are
cfg-gated adapters inside the module; the Windows generation-cancel
rule, WebContext UDF, pending-URL replay, and unavailable messaging
are moved, not rewritten. PreviewPanel keeps chrome + MCP broker and
is the only production caller. The --preview-smoke harness now drives
the same lifecycle interface through one doc-hidden accessor — the
three AppShell smoke pass-throughs and all harness-only panel state
are deleted. Verified: full --preview-smoke PASS on macOS,
x86_64-pc-windows-gnu clippy clean.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architecture round, candidate C4.
Problem —
preview_panel.rs(1,796 lines) held four concerns at one stateful seam: chrome UI, per-conversation webview cache (incl. draft→stored key migration), platform creation (macOS sync + the Windows generation-tagged async slot machine from #253), and the MCP op broker. Callers had to know hidden ordering facts, and the--preview-smokeharness could only reach lifecycle through three shallow AppShell pass-throughs plus harness-only panel state — evidence the lifecycle had no real interface.Change
preview_panel/lifecycle.rs: session-keyed browser lifecycle —ensure / navigate / set_visible / drop_view / prunewithAvailability::{Ready, Starting(CreationPhase), Unavailable}; the two ordering facts (native children must hide before their GPUI owner unmounts; value ops wait for warmth) are documented on the interface itself. Draft→stored key migration lives with the cache it migrates.build_as_child; Windows shared-WebContext asyncbuild_as_child_asyncwith the exact generation-cancel rule (live window + live panel + live generation) preserved; unavailable as the third state. Moved, not rewritten — this path shipped a crash fix days ago.PreviewPanelkeeps chrome + broker + store mirroring as the only production caller. The smoke harness drives the same lifecycle interface via one doc-hiddenAppShell::preview_lifecycleaccessor; all three smoke pass-throughs and the harness-only panel state are deleted.Wins — three adapters justify the seam; platform bugs stay in their adapter; the harness exercises production lifecycle, not a parallel surface.
Verification — full
--preview-smokeon macOS: all 10 phases + PASS (including drop-during-create and recreate-after-inflight-drop);cargo clippy --target x86_64-pc-windows-gnu -p tcode -- -D warningsclean; fmt / clippy / full workspace tests green.🤖 Generated with Claude Code