Remove crackL2BookFast, keep the general simdjson path as the sole l2Book parser - #159
Merged
Merged
Conversation
Base automatically changed from
perf/websocket-parser-validate-json-toggle
to
main
September 10, 2026 10:56
…Book parser crackL2BookFast (a hand-rolled scanTo/memchr byte-scanner) showed no measurable speedup over crackL2Book in the hyperliquid-md-benchmark replay harness - fast path vs general path percentiles overlapped across repeated runs, unlike the clean, consistent effect measured for the validateJson toggle. It also duplicated parsing logic that had to be kept in sync with crackL2Book, and entirely bypassed simdjson's structural parsing (and the validateJson safety net) whenever it succeeded, on the theory that the byte pattern looked right - a separate correctness surface for no measured benefit. Removes it, WebsocketParsingUtils::scanTo/parseUint64Fast (now unused), and the fast-path-specific test comments/names. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Le73N2EZjGLsCqmCScAse
TuxedoFish
force-pushed
the
perf/remove-l2book-fast-path
branch
from
September 10, 2026 14:13
bbc8281 to
1883f51
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 70.29% 70.09% -0.21%
==========================================
Files 54 54
Lines 8900 8840 -60
Branches 539 530 -9
==========================================
- Hits 6256 6196 -60
Misses 2639 2639
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crackL2BookFast(hand-rolledscanTo/memchrbyte-scanner) showed no measurable speedup overcrackL2Book(general simdjson path) inhyperliquid-md-benchmark's replay harness - percentiles overlapped across repeated runs.Test plan
ctest(29/29 passing, including renamedL2BookCompact/L2BookWithWhitespace)hyperliquid-md-benchmarkreplay:levelsSeenoutput identical before/after removal🤖 Generated with Claude Code
https://claude.ai/code/session_018Le73N2EZjGLsCqmCScAse