Drop secp256k1 overlay port now that vcpkg's registry port has the recovery feature - #160
Open
TuxedoFish wants to merge 1 commit into
Open
Drop secp256k1 overlay port now that vcpkg's registry port has the recovery feature#160TuxedoFish wants to merge 1 commit into
TuxedoFish wants to merge 1 commit into
Conversation
…covery feature microsoft/vcpkg#53838 merged and added an opt-in "recovery" feature to the registry secp256k1 port (SECP256K1_ENABLE_MODULE_RECOVERY), which we needed for the recoverable ECDSA signatures our EIP-712 signing path relies on and previously had to work around with a local overlay port. Removes vcpkg-overlay-ports/ and vcpkg-configuration.json's overlay-ports entry, and changes vcpkg.json's secp256k1 dependency to request the "recovery" feature from the registry port directly. Fixes #120 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Le73N2EZjGLsCqmCScAse
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 54 54
Lines 8840 8840
Branches 530 530
=======================================
Hits 6196 6196
Misses 2639 2639
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recoveryfeature to the registrysecp256k1port - theSECP256K1_ENABLE_MODULE_RECOVERYflag we needed for recoverable ECDSA signatures in our EIP-712 signing path and previously had to work around with a local overlay port.vcpkg-overlay-ports/andvcpkg-configuration.json'soverlay-portsentry.vcpkg.json'ssecp256k1dependency to{"name": "secp256k1", "features": ["recovery"]}.Fixes #120
Test plan
secp256k1_recovery.hinstalls from the registry port, confirming the feature resolves without the overlay.ctest(29/29 passing, includingsigning_test/signing_helpers_testwhich exercise recoverable ECDSA)🤖 Generated with Claude Code
https://claude.ai/code/session_018Le73N2EZjGLsCqmCScAse