Repository navigation
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
このPRによるapi.jsonの差分 |
Contributor
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (3 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
⚙️ Backend Diagnostics ReportMemory: After GC(No significant changes) V8 Heap Snapshot Statistics
|
mattyatea
marked this pull request as draft
October 6, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
VC モデレーターもステージ通話の発言リクエストを承認・拒否し、非ホスト参加者のスピーカー/リスナーを切り替えられるようにします。
リスナーをスピーカーにするとミュート状態で開始し、受信中の音声接続を維持します。本人がミュートを解除すると、現在の役割に合わせて認証情報を更新し、既存の WebRTC 接続にマイクを追加します。設定文言と通話プロトコルの説明も更新しました。
Why
発言承認がホストに限定されており、VC モデレーターが対応できませんでした。また、スピーカー昇格時に接続を作り直すため、受信音声が途切れていました。
Additional info (optional)
flowchart LR A["ホスト/参加中のVCモデレーターが承認"] --> B["ミュート状態でスピーカーへ変更"] B --> C["既存の音声受信を継続"] C --> D["本人がミュート解除"] D --> E["現在の役割で認証情報を更新"] E --> F["既存接続にマイクを追加"]pnpm --filter frontend test test/unit/calls-session.test.ts test/unit/calls-media-controller.test.ts(71 件)pnpm --filter backend test --run test/unit/core/calls/CallsRoomService.ts test/unit/core/calls/CallsMediaEndpoints.ts(100 件)node scripts/check-shipping.mjs --base origin/develop(変更ファイル lint、SPDX、locale safety)とgit diff --check@zip.js/zip.jsがないため停止。frontend 型チェックは共有環境の misskey-js/i18n ビルド済み型と最新ソースの不一致、および既存のbeforeunloadテストの型エラーで停止しています。両パッケージの型チェック成功は未確認です。API の入力・出力スキーマと DB スキーマは変更していません。関連 Issue は検索しましたが見つからず、ユーザーからの修正依頼に基づく PR です。CHANGELOG は依頼がないため編集していません。
CHANGELOG 候補:VC モデレーターによる発言承認と、ミュート状態でのスムーズなスピーカー切り替えに対応。
Checklist