fix: `insertInlineContent` adding content after cursor (BLO-1356) by matthewlipski · Pull Request #3112 · TypeCellOS/BlockNote

matthewlipski · 2026-09-23T08:54:03Z

Summary

This PR makes it so that insertInlineContent inserts the content just before the cursor rather than just after.

Closes #3064

Rationale

This is more in-line with expected behavior.

Changes

Set the tiptapEditor.isEditorContentInitialized flag on mount.

Impact

N/A

Testing

Added component test.

Screenshots/Video

N/A

Checklist

Code follows the project's coding standards.
Unit tests covering the new feature have been added.
All existing tests pass.
The documentation has been updated to reflect the new feature

Additional Notes

N/A

Summary by CodeRabbit

Bug Fixes
- Typing after inserting styled text now continues in the correct position, including after the editor is remounted.

vercel · 2026-09-23T08:54:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
blocknote	Ready	Preview	Sep 25, 2026 4:37pm UTC
blocknote-website	Ready	Preview	Sep 25, 2026 4:37pm UTC

coderabbitai · 2026-09-23T08:54:57Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8d6dbc65-508c-49cb-872f-3782f0122154

📥 Commits

Reviewing files that changed from the base of the PR and between 908f0b5 and 0a37b4d.

📒 Files selected for processing (2)

packages/core/src/editor/BlockNoteEditor.ts
packages/react/src/schema/ReactStyleSpec.browser.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

BlockNoteEditor now tracks content initialization during mount and unmount. A React browser test checks typing after styled text insertion, including after an API remount. The React Vitest configuration excludes browser test files.

Changes

React style caret positioning

Layer / File(s)	Summary
Editor mounting and caret regression test `packages/core/src/editor/BlockNoteEditor.ts`, `packages/react/src/schema/ReactStyleSpec.browser.test.tsx`, `packages/react/vite.config.ts`	BlockNoteEditor exposes and updates the content-initialization flag during mount and unmount. The browser test checks typing after styled text insertion, including after an API remount. Vitest excludes browser test files from the React package test run.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: yousefed

Merge Risk: ⚪ Minimal · up to 0a37b

The change preserves the initialization ordering needed for styled React marks, and its regression test remains in the CI browser suite. No merge-blocking risk is established.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 0a37b

The change appears limited to editor mounting and caret behavior. No new security exposure was identified, but the renderer’s failure behavior has not been fully verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The observed effect is confined to an editor instance’s mounting and styled-text editing flow; the inspected change does not establish tenant, service, credential, or deployment exposure.

Trust Boundaries and Controls

inferred — The inspected React caller passes a DOM element to the existing editor lifecycle methods. No new trust or authority transition is established by the flag writes in that path.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the `insertInlineContent` cursor-positioning fix and matches the pull request objective.
Description check	✅ Passed	The description includes all required sections and explains the rationale, primary change, impact, testing, and checklist status. The Changes section could mention the browser test and Vite configurat…
Linked Issues check	✅ Passed	Issue [`#3064`] requires the caret to remain after text inserted with a custom React style. `BlockNoteEditor.mount` now sets `isEditorContentInitialized` after TipTap mounts, and `unmount` clears it bef…
Out of Scope Changes check	✅ Passed	The changed editor flag, its type declaration, the React-style browser test, and the Vitest exclusion all support the fix for [`#3064`]. No unrelated change is demonstrated.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit taps the editor pane,
Styled text appears in tidy train.
It hops away, then comes once more,
And types its words where they belong.
The caret stays; the burrow’s bright!}

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-23T09:04:51Z

PR Preview Action v1.8.1
🚀 View preview at https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3112/
Built to branch `gh-pages` at 2026-09-25 16:48 UTC. Preview will be ready when the GitHub Pages deployment is complete.

pkg-pr-new · 2026-09-23T09:16:02Z

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3112

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3112

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3112

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3112

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3112

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3112

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3112

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3112

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3112

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3112

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3112

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3112

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3112

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3112

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3112

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3112

commit: 0a37b4d

nperez0111 · 2026-09-23T09:27:33Z

+      const tiptapEditor: ReactRenderer["editor"] = editor._tiptapEditor;
+      tiptapEditor.contentComponent = portalManager;
      if (element) {
        editor.mount(element);
+        // Render subsequent React node/mark views synchronously so their
+        // contentDOM is attached when ProseMirror places the selection.
+        tiptapEditor.isEditorContentInitialized = true;
      } else {
+        tiptapEditor.isEditorContentInitialized = false;
        editor.unmount();


I'm confused how the issue relates to this fix. Also, shouldn't this be done as part of the editor.mount & editor.unmount functions?

When inserting a React mark, is attaches contentDOM async via a ref. When isEditorContentInitialized = false, the PM state/view correctly update the document and view, and the issue comes when PM tries to sync its selection with the browser. Because the content is not yet rendered, the browser is unable to set the selection to the given offset, so the whole selection update is rejected. Rendering synchronously causes the content to be rendered straight away, so you don't get issues with PM syncing its internal selection with the browser's.

Made inline content get inserted before cursor instead of after

d8f87ca

matthewlipski requested a review from nperez0111 September 23, 2026 08:54

Updated test config

908f0b5

vercel Bot deployed to Preview – blocknote September 23, 2026 09:07 View deployment

vercel Bot deployed to Preview – blocknote-website September 23, 2026 09:08 View deployment

nperez0111 reviewed Sep 23, 2026

View reviewed changes

Moved fix to mount

0a37b4d

vercel Bot deployed to Preview – blocknote September 25, 2026 16:36 View deployment

vercel Bot deployed to Preview – blocknote-website September 25, 2026 16:37 View deployment

Navigation Menu

Uh oh!

fix: `insertInlineContent` adding content after cursor (BLO-1356) - #3112

fix: `insertInlineContent` adding content after cursor (BLO-1356)#3112
matthewlipski wants to merge 3 commits into
mainfrom
insert-inline-content-fix

matthewlipski commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 23, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-09-25 16:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

pkg-pr-new Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

nperez0111 Sep 23, 2026

Uh oh!

matthewlipski Sep 25, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

matthewlipski commented Sep 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rationale

Changes

Impact

Testing

Screenshots/Video

Checklist

Additional Notes

Summary by CodeRabbit

Uh oh!

vercel Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Security Architecture Review

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-09-25 16:48 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

pkg-pr-new Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nperez0111 Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

matthewlipski Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matthewlipski commented Sep 23, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Sep 23, 2026 •

edited

Loading

coderabbitai Bot commented Sep 23, 2026 •

edited

Loading

github-actions Bot commented Sep 23, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-09-25 16:48 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

pkg-pr-new Bot commented Sep 23, 2026 •

edited

Loading

matthewlipski Sep 25, 2026 •

edited

Loading