feat: prepare server 1.7.0 - #81
Merged
Merged
Conversation
Add an account-scoped read model for subscription channels and their complete group assignments so the frontend can render and edit memberships without issuing one filtered subscription request per group. Constraint: Keep the shared SubscriptionItem unchanged because feeds, backups, imports, RSS, and recommendations reuse it Rejected: Add groupIds to SubscriptionItem | would query and serialize group data in unrelated paths Rejected: Fetch each group projection from the frontend | creates N requests for N groups Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep groupIds account-scoped and include empty arrays for ungrouped subscriptions Tested: JDK 25 clean check, 1,132 tests, shadowJar, OpenAPI validation, and live HTTP QA Not-tested: Frontend integration is intentionally deferred
Let clients add or remove many subscribed channels from one group in a single account-scoped transaction while preserving the shipped singular request forms. Constraint: The singular membership contract shipped in v1.6.0 and must remain compatible Rejected: Cross-group membership delta endpoint | bulk organization is naturally scoped to one group Rejected: Repeated delete query parameters | encoded channel URLs can exceed practical URL limits Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep batch writes bounded, atomic, idempotent, and protected by SubscriptionMutationLock Tested: JDK 25 clean check, 1,134 tests, coverage, shadowJar, OpenAPI validation, focused retry regression, and live HTTP QA Not-tested: Frontend and Android integration are intentionally deferred
Return a client error when a DELETE supplies both the legacy URL query parameter and a JSON membership body so the server cannot silently apply only part of the requested mutation. Constraint: Preserve both shipped query-only deletion and the new body-only batch contract Rejected: Give the query parameter precedence | silently ignores a valid batch body Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep the two DELETE input forms mutually exclusive at the HTTP boundary Tested: Red-green route regression, JDK 25 check with 1,135 tests, coverage, shadowJar, OpenAPI validation, and live HTTP QA Not-tested: Frontend integration remains intentionally deferred
Reject oversized membership bodies before they can be fully buffered and validate each submitted channel URL at the API boundary. Treat any non-empty DELETE body as present so whitespace cannot bypass query/body exclusivity. Constraint: Preserve the existing singular and batch membership contracts Rejected: Rely on Content-Length alone | chunked requests can omit the header Confidence: high Scope-risk: narrow Directive: Keep request limits aligned with the OpenAPI membership schemas Tested: ./gradlew --no-daemon clean check shadowJar validateOpenApi Tested: Live HTTP checks for body limits, URL length, and DELETE ambiguity
Repair avatars only after applying subscription selection so unrelated channels neither consume the repair budget nor receive database writes. Serialize membership projections with account subscription mutations so channel data and group assignments come from one coherent state. Constraint: Preserve avatar repair for unfiltered and membership projection responses Rejected: Repair all subscriptions before filtering | unrelated rows consume the repair limit and receive writes Rejected: Add a new snapshot transaction API | the existing per-user mutation lock already serializes group changes Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep membership projections and mutations on SubscriptionMutationLock Tested: JDK 25 clean check, 1,141 tests, shadowJar, OpenAPI validation, and live HTTP lock-contention QA
feat: expose and bulk-update subscription group memberships
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production behavior
Portability jobs expose format capabilities, progress and diagnostics while keeping unsupported categories explicit.
SABR media responses are streamed progressively. Initialization and bootstrap work is reused where possible, and playback recovery keeps the current playhead and rewind preparation consistent.
Subscription groups retain the existing singular routes while adding sorted channel-centric memberships and bounded atomic batch updates.
Deployment requirements
Server creates the portability and subscription-group tables through normal schema initialization. No manual database migration or configuration change is required.
Tests
./gradlew test --no-daemon./gradlew check --no-daemon./gradlew shadowJar --no-daemongit diff --checkRollback
Restore Server revision
744d26da.