Fix link checker - #113
Merged
Merged
Fix link checker#113
Conversation
…a different way." This reverts commit d2e9a7b.
samcunliffe
force-pushed
the
sc/fix-link-checker
branch
2 times, most recently
from
September 11, 2026 11:27
8e41900 to
d37be31
Compare
samcunliffe
force-pushed
the
sc/fix-link-checker
branch
from
September 11, 2026 11:39
d37be31 to
e00c97f
Compare
For our purposes we don't want to flag them.
@dpshelio this is what I mean by maintenance burden.
samcunliffe
force-pushed
the
sc/fix-link-checker
branch
from
September 11, 2026 12:47
513a558 to
d496aa7
Compare
samcunliffe
commented
Sep 11, 2026
samcunliffe
commented
Sep 11, 2026
Member
Author
|
This is a horrible mess of too many testing commits. Be sure to squash! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
The link checker has passed successfully 🎉! No broken links were found. |
Member
Author
|
When this is merged, I'm going to make these checks required. |
samcunliffe
commented
Sep 15, 2026
| link: | ||
| funding: UCL Research Culture Seed Funds | ||
| link_call: https://www.ucl.ac.uk/research/strategy-environment/research-culture-ucl/get-involved/research-culture-seed-fund | ||
| link_call: |
Member
Author
There was a problem hiding this comment.
The rendered page links to itself. Which is probably out of scope to fix for this PR. If a link_call is not provided, it should simply write the name of the cal in plain text.
samcunliffe
added
website
paddyroddy
approved these changes
Sep 15, 2026
paddyroddy
left a comment
paddyroddy
left a comment
Member
There was a problem hiding this comment.
Lots of work here, thanks for fixing
Comment on lines
+13
to
+15
| # Some parts of the upstream theme cause errors because they don't prepend https. We don't fix the theme because | ||
| # it will be updated to the new branding soon. So just suppress all of this for now. Remove when the theme is | ||
| # updated. All social media links on every theme-rendered page are like this!! |
Member
There was a problem hiding this comment.
It is annoying the lychee seems to complain about so many URLs
Member
Author
There was a problem hiding this comment.
Yes. Yes it is. Also the theme is starting to work against us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing yearly reports link will be fixed in #90