feat(ui5-tokenizer): announce token deletion - #14010
Conversation
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-14010--ui5-webcomponents-preview.netlify.app |
| this._handleCurrentItemAfterDeletion(nextToken); | ||
|
|
||
| this._tokenDeleting = true; | ||
| this._announceTokenDeletion(1); |
There was a problem hiding this comment.
You can try to move the delete announcement inside _handleCurrentItemAfterDeletion (probably pass an argument of the number of deleted tokens) because at the moment the focus goes to the next token, its info is announced immediately regardless the timeout, and after that "1 token deleted is announced" which is confusing because of the new token information
I would also leave it without a value in case of 1 token, because the hardcoded number looks strange
There was a problem hiding this comment.
I tried moving the announcement before the focus logic in _handleCurrentItemAfterDeletion, however screen readers prioritize the focus-change speech over the aria-live announcement. We already discussed this with design side and we agreed to leave it to the screen readers to decide what should be announced first.
For the second issue, the hardcoded number has been refactored.
a120cd0 to
ae1506a
Compare
GitHub Actions
Inactive
2 participants
BGSOFUIRILA-4445