fix(ui5-date-picker): sync disabled state to inner input immediately on change - #14019
Open
unazko wants to merge 1 commit into
Open
fix(ui5-date-picker): sync disabled state to inner input immediately on change#14019unazko wants to merge 1 commit into
unazko wants to merge 1 commit into
Conversation
…on change Issue: When was toggled via a framework (e.g. React), the host element updated synchronously but the inner only updated in the next animation frame. This gap allowed the browser's accessibility tree to snapshot a stale disabled state that never cleared, leaving the inner input reported as disabled even after the component was re-enabled. Solution: Override 'onInvalidation' to propagate 'disabled' to '_dateTimeInput' immediately when the property changes, before the scheduled re-render fires. This closes the one-frame gap and ensures the accessibility tree always reflects the correct state. Fixes #14006
unazko
temporarily deployed
to
netlify-preview
September 2, 2026 14:07 — with
GitHub Actions
Inactive
1 task
|
🚀 Deployed on https://pr-14019--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When
disabledwas toggled via a framework (e.g. React), the host element updated synchronously but the inner only updated in the next animation frame. This gap allowed the browser's accessibility tree to snapshot a stale disabled state that never cleared, leaving the inner input reported as disabled even after the component was re-enabled.Solution:
Override
onInvalidationto propagatedisabledto_dateTimeInputimmediately when the property changes, before the scheduled re-render fires. This closes the one-frame gap and ensures the accessibility tree always reflects the correct state.Fixes #14006