Repository navigation
fix(ui5-calendar): show correct year range when secondaryCalendarType… - #14191
Merged
Merged
Conversation
… is configured globally
|
🚀 Deployed on https://pr-14191--ui5-webcomponents-preview.netlify.app |
GDamyanov
requested changes
Oct 23, 2026
GDamyanov
approved these changes
Oct 23, 2026
|
🧹 Preview deployment cleaned up: https://pr-14191--ui5-webcomponents.netlify.app |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the secondary calendar type was set globally (rather than through the
secondaryCalendarTypeproperty), the Year Picker displayed an incorrect range of years.This happened because
hasSecondaryCalendarTypeonly looked at thesecondaryCalendarTypeproperty and ignored the globally configured value. As a result, the Calendar laid out a 20-year range while the Year Picker rendered an 8-year grid, so the two no longer matched.The fix makes
hasSecondaryCalendarTyperead the resolved calendar type (property or global configuration), so the Calendar and Year Picker stay in sync in both cases.Fixes: #14185