Skip to content

Clean up and vectorize the face_areas API #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajeeja wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Clean up and vectorize the face_areas API #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f9510f7
Clean up and vectorize the face_areas API
rajeeja Jul 15, 2026
8d71e16
improve face_areas docstring, type hinting
Sevans711 Jul 16, 2026
fca9c84
forgot to pre-commit run; fixes ruff formatting
Sevans711 Jul 16, 2026
fa7c8ed
Merge branch 'main' into rajeeja/area_cleanup
erogluorhan Jul 17, 2026
9ee6430
Warn when total face area exceeds unit-sphere area
rajeeja Jul 17, 2026
0a74cd6
Address review: UxDataArray return, plots, and face-area benchmark
rajeeja Jul 17, 2026
1be8bde
Merge branch 'main' into rajeeja/area_cleanup
rajeeja Jul 17, 2026
14d4a2e
Remove total-area sanity check (unreliable for parsed physical-unit a…
rajeeja Jul 17, 2026
0d13dc3
resolve merge conflict, merge main
rajeeja Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions benchmarks/mpas_ocean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ def teardown(self, resolution, *args, **kwargs):
del self.uxgrid


class FaceAreas(GridBenchmark):
def time_compute_face_areas(self, resolution):
self.uxgrid.compute_face_areas()

def peakmem_compute_face_areas(self, resolution):
self.uxgrid.compute_face_areas()


class Gradient(DatasetBenchmark):
def time_gradient(self, resolution):
self.uxds[data_var].gradient()
Expand Down
Loading