Skip to content

Fix face_areas type hints and add compute_face_areas return type #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sevans711 merged 1 commit into from
Jul 20, 2026
Merged

Fix face_areas type hints and add compute_face_areas return type #1592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions uxarray/grid/grid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1940,9 +1940,9 @@ def copy(self):

def calculate_total_face_area(
self,
quadrature_rule: str | None = "triangular",
order: int | None = 4,
latitude_adjusted_area: bool | None = False,
quadrature_rule: str = "triangular",
order: int = 4,
latitude_adjusted_area: bool = False,
) -> float:
"""Function to calculate the total surface area of all the faces in a
mesh.
Expand Down Expand Up @@ -1978,10 +1978,10 @@ def calculate_total_face_area(

def compute_face_areas(
self,
quadrature_rule: str | None = "triangular",
order: int | None = 4,
latitude_adjusted_area: bool | None = False,
):
quadrature_rule: str = "triangular",
order: int = 4,
latitude_adjusted_area: bool = False,
) -> tuple[np.ndarray, np.ndarray]:
"""Face areas calculation function for grid class, calculates area of
all faces in the grid.

Expand Down Expand Up @@ -2022,10 +2022,10 @@ def compute_face_areas(

def _compute_face_areas(
self,
quadrature_rule: str | None = "triangular",
order: int | None = 4,
latitude_adjusted_area: bool | None = False,
):
quadrature_rule: str = "triangular",
order: int = 4,
latitude_adjusted_area: bool = False,
) -> tuple[np.ndarray, np.ndarray]:
"""Internal face areas calculation function for grid class, calculates area of
all faces in the grid.

Expand Down