Skip to content

Optimize _get_faces_constLat_intersection_info - #1799

Draft
cmdupuis3 wants to merge 9 commits into
UXARRAY:mainfrom
cmdupuis3:cmd/optimize_integrate
Draft

cmdupuis3 wants to merge 9 commits into
UXARRAY:mainfrom
cmdupuis3:cmd/optimize_integrate

Conversation

@cmdupuis3

@cmdupuis3 cmdupuis3 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1570

Maybe related to #790

Overview

PR Checklist

General

  • An issue is created and linked
  • Added appropriate labels (if your uxarray repo permissions allow it)
  • Filled out Overview and Expected Usage (if applicable) sections

Testing & Benchmarking

  • There is adequate test coverage of changes from this PR (add new tests if needed)
  • If this PR could affect performance, ran ASV benchmarks and confirmed they show expected behavior (add a new benchmark if necessary)

Documentation and Examples

  • Docstrings updated with any function changes, and included in all new functions
  • User (public) functions added to docs/api.rst; internal (private) function names start with an underscore (_)

AI Disclosure

AI Usage: Claude Opus 5

  • I have tested and take responsibility for all AI-generated content in my PR.

@cmdupuis3 cmdupuis3 self-assigned this Sep 30, 2026
@cmdupuis3 cmdupuis3 added scalability Related to scalability & performance efforts run-benchmark Run ASV benchmark workflow labels Sep 30, 2026
cmdupuis3 and others added 2 commits September 30, 2026 13:30
Adapt the Numba intersection kernel to two changes on main:

- UXARRAY#1727 changed gca_const_lat_intersection to return a tuple of tuples
  instead of a (2, 3) array, so the kernel now reads points as
  intersections[r][i] rather than intersections[r, i].
- UXARRAY#1705 made the no-intersection and concave-face errors format the face
  array into their messages, which Numba cannot do, so both raises move
  from the kernel into the Python wrapper. The kernel now also returns the
  number of non-dummy edges that the concave check needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

ASV Benchmarking

Benchmark Comparison Results

Benchmarks that have improved:

Change Before [55e15bb] <v2026.10.1~8> After [4a070cc] Ratio Benchmark (Parameter)
- 384±7ms 2.73±0.03ms 0.01 mpas_ocean.AzimuthalAverage.time_azimuthal_average('120km')
- 329±4ms 1.04±0.05ms 0.00 mpas_ocean.AzimuthalAverage.time_azimuthal_average('480km')
- 755k 669k 0.89 mpas_ocean.NeighborhoodDask.track_peakmem_mean('480km', 'grid_chunks')
- 20.0±0.4ms 17.6±0.2ms 0.88 mpas_ocean.RemapUpsample.time_inverse_distance_weighted_remapping
- 2.30±0.02s 15.4±0.2ms 0.01 mpas_ocean.ZonalAverage.time_zonal_average_robust('120km')
- 575±4ms 6.08±0.5ms 0.01 mpas_ocean.ZonalAverage.time_zonal_average_robust('480km')
* failed 192±2μs n/a open_dataset.OpenDataset.time_open_dataset('grid', 'dataset')
* failed 1.22±0.1ms n/a open_dataset.OpenDataset.time_open_dataset('grid', 'file')
- 4.07±0.02s 1.47±0s 0.36 plots.PlotContour.time_contour_projected
- 71.1±2ms 10.7±0.3ms 0.15 subset.BoundingBox.time_bounding_box('120km')
- 13.9±0.2ms 5.95±0.2ms 0.43 subset.BoundingBox.time_bounding_box('480km')
- 3.38M 2.38M 0.70 subset.BoundingBox.track_peakmem_bounding_box('120km')
- 328k 203k 0.62 subset.BoundingBox.track_peakmem_bounding_box('480km')
- 81.8±0.8ms 3.74±0.1ms 0.05 subset.BoundingBoxHealpix.time_bounding_box(6)
- 1.29±0.01s 14.4±0.6ms 0.01 subset.BoundingBoxHealpix.time_bounding_box(8)
- 5.53M 2.18M 0.40 subset.BoundingBoxHealpix.track_peakmem_bounding_box(6)
- 88.3M 13.2M 0.15 subset.BoundingBoxHealpix.track_peakmem_bounding_box(8)
- 1.12±0.01s 726±8ms 0.65 to_raster.ToRaster.time_to_raster((10000.0, 10.0))
- 2.83±0.01s 1.52±0.01s 0.54 to_raster.ToRaster.time_to_raster((10000.0, 100.0))
- 3.24±0.01s 1.78±0.01s 0.55 to_raster.ToRaster.time_to_raster((100000.0, 100.0))
- 479±10μs 111±5μs 0.23 to_xarray.UxDataArrayToXarray.time_to_xarray(10)
- 78.6±0.7ms 233±2μs 0.00 to_xarray.UxDatasetToXarray.time_to_xarray((100, 10))
- 7.77±0.02s 2.13±0.02ms 0.00 to_xarray.UxDatasetToXarray.time_to_xarray((1000, 100))
- 87.1±0.9ms 503±2μs 0.01 to_xarray.UxDatasetToXarray.time_to_xarray_healpix((100, 10))
- 8.25±0.03s 4.65±0.04ms 0.00 to_xarray.UxDatasetToXarray.time_to_xarray_healpix((1000, 100))

Benchmarks that have stayed the same:

Change Before [55e15bb] <v2026.10.1~8> After [4a070cc] Ratio Benchmark (Parameter)
813±20μs 787±30μs 0.97 connectivity.Connectivity.time_edge_face('120km')
323±20μs 322±10μs 1.00 connectivity.Connectivity.time_edge_face('480km')
4.62±0.1ms 4.42±0.1ms 0.96 connectivity.Connectivity.time_edge_node('120km')
804±30μs 801±20μs 1.00 connectivity.Connectivity.time_edge_node('480km')
47.1±5μs 44.9±1μs 0.95 connectivity.Connectivity.time_face_edge('120km')
39.5±7μs 37.3±7μs 0.95 connectivity.Connectivity.time_face_edge('480km')
594±20μs 581±10μs 0.98 connectivity.Connectivity.time_face_face('120km')
308±10μs 310±9μs 1.00 connectivity.Connectivity.time_face_face('480km')
39.8±3μs 52.3±20μs ~1.31 connectivity.Connectivity.time_face_node('120km')
39.6±20μs 42.3±4μs 1.07 connectivity.Connectivity.time_face_node('480km')
382±20μs 506±10μs ~1.33 connectivity.Connectivity.time_n_nodes_per_face('120km')
274±20μs 275±8μs 1.00 connectivity.Connectivity.time_n_nodes_per_face('480km')
1.06±0.03ms 1.03±0.05ms 0.98 connectivity.Connectivity.time_node_edge('120km')
342±9μs 325±10μs 0.95 connectivity.Connectivity.time_node_edge('480km')
68.0±3ms 66.6±0.9ms 0.98 connectivity.Connectivity.time_node_face('120km')
4.14±0.02ms 3.93±0.03ms 0.95 connectivity.Connectivity.time_node_face('480km')
1.42M 1.42M 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_edge_face('120km')
105k 105k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_edge_face('480km')
6.48M 6.48M 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_edge_node('120km')
419k 419k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_edge_node('480km')
2.05k 2.05k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_edge('120km')
2.05k 2.05k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_edge('480km')
1.6M 1.6M 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_face('120km')
101k 101k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_face('480km')
2.18k 2.18k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_node('120km')
2.18k 2.18k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_face_node('480km')
240k 240k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_n_nodes_per_face('120km')
26k 26k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_n_nodes_per_face('480km')
1.9M 1.9M 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_node_edge('120km')
127k 127k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_node_edge('480km')
11.9M 11.9M 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_node_face('120km')
747k 747k 1.00 connectivity.ConnectivityTracemalloc.track_peakmem_node_face('480km')
6.53±1ms 7.07±0.06ms 1.08 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
2.09±0.06ms 2.16±0.06ms 1.03 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
7.39±9ms 8.15±8ms ~1.10 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
1.24±0.03ms 1.24±0.02ms 1.00 face_bounds.FaceBounds.time_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
57.3k 57.3k 1.00 face_bounds.FaceBounds.track_nbytes_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
12.3k 12.3k 1.00 face_bounds.FaceBounds.track_nbytes_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
123k 123k 1.00 face_bounds.FaceBounds.track_nbytes_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
128 128 1.00 face_bounds.FaceBounds.track_nbytes_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
1.27M 1.27M 1.00 face_bounds.FaceBounds.track_nbytes_grid_with_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
50.1k 50.1k 1.00 face_bounds.FaceBounds.track_nbytes_grid_with_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
1.48M 1.48M 1.00 face_bounds.FaceBounds.track_nbytes_grid_with_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
712 712 1.00 face_bounds.FaceBounds.track_nbytes_grid_with_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
1.78M 1.78M 1.00 face_bounds.FaceBounds.track_peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
1.78M 1.75M 0.99 face_bounds.FaceBounds.track_peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
1.94M 1.92M 0.99 face_bounds.FaceBounds.track_peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
35.3k 35.3k 1.00 face_bounds.FaceBounds.track_peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
1.14±0.03μs 1.17±0.02μs 1.03 geometry_kernels.AccucrossKernels.time_accucross
2.61±0.1μs 2.62±0.04μs 1.00 geometry_kernels.AccucrossKernels.time_accucross_pair
511±30ns 480±10ns 0.94 geometry_kernels.EFTPrimitives.time_acc_sqrt_re
471±30ns 456±20ns 0.97 geometry_kernels.EFTPrimitives.time_diff_of_products
436±30ns 416±20ns 0.95 geometry_kernels.EFTPrimitives.time_two_prod
455±20ns 421±20ns 0.92 geometry_kernels.EFTPrimitives.time_two_sum
721±40ns 686±30ns 0.95 geometry_kernels.GCAConstLatIntersection.time_accux_constlat_kernel
786±30ns 742±9ns 0.94 geometry_kernels.GCAConstLatIntersection.time_gca_const_lat_intersection
851±10ns 812±40ns 0.95 geometry_kernels.GCAConstLatIntersection.time_try_gca_const_lat_intersection
556±5ns 571±10ns 1.03 geometry_kernels.GCAGCAIntersection.time_accux_gca_kernel
656±30ns 661±10ns 1.01 geometry_kernels.GCAGCAIntersection.time_gca_gca_intersection
751±30ns 736±10ns 0.98 geometry_kernels.GCAGCAIntersection.time_try_gca_gca_intersection
51.1±1μs 49.7±0.6μs 0.97 geometry_kernels.OrientPredicates.time_on_minor_arc
50.8±0.4μs 49.6±0.7μs 0.98 geometry_kernels.OrientPredicates.time_orient3d_on_sphere
2.46±0.01ms 2.44±0.03ms 0.99 geometry_samebody.SameBodyConstLat.time_accux_dispatch
1.02±0ms 1.02±0ms 1.00 geometry_samebody.SameBodyConstLat.time_accux_kernel
1.64±0ms 1.64±0ms 1.00 geometry_samebody.SameBodyConstLat.time_fp64_dispatch
120±0.8μs 119±0.4μs 0.99 geometry_samebody.SameBodyConstLat.time_fp64_kernel
29.7±0.2ms 29.7±0.05ms 1.00 geometry_samebody_gcagca.SameBodyGcaGca.time_accux_dispatch
6.27±0.04ms 6.27±0.01ms 1.00 geometry_samebody_gcagca.SameBodyGcaGca.time_accux_kernel
23.8±0.2ms 23.8±0.05ms 1.00 geometry_samebody_gcagca.SameBodyGcaGca.time_fp64_dispatch
862±7μs 859±2μs 1.00 geometry_samebody_gcagca.SameBodyGcaGca.time_fp64_kernel
887±10ms 969±9ms 1.09 import.Imports.timeraw_import_uxarray
1 1 1.00 lazy_grid_construction.LazyGridConstruction.track_computes_isel
2 2 1.00 lazy_grid_construction.LazyGridConstruction.track_computes_open_grid_chunked
67.9±2ms 66.9±0.9ms 0.99 lazy_grid_construction.OpenGridChunked.time_open_grid('120km')
96.7±3ms 95.7±2ms 0.99 lazy_grid_construction.OpenGridChunked.time_open_grid('480km')
1.99M 1.99M 1.00 lazy_grid_construction.OpenGridChunked.track_peakmem_open_grid('120km')
2.3M 2.3M 1.00 lazy_grid_construction.OpenGridChunked.track_peakmem_open_grid('480km')
2.41±0.02ms 2.60±0.04ms 1.08 mpas_ocean.CheckNorm.time_check_norm('120km')
1.91±0.04ms 1.97±0.01ms 1.03 mpas_ocean.CheckNorm.time_check_norm('480km')
1.14±0.02ms 1.20±0.04ms 1.05 mpas_ocean.ConnectivityConstruction.time_face_face_connectivity('120km')
516±10μs 533±20μs 1.03 mpas_ocean.ConnectivityConstruction.time_face_face_connectivity('480km')
631±20μs 638±20μs 1.01 mpas_ocean.ConnectivityConstruction.time_n_nodes_per_face('120km')
593±20μs 581±6μs 0.98 mpas_ocean.ConnectivityConstruction.time_n_nodes_per_face('480km')
4.82±0.07ms 5.08±0.08ms 1.05 mpas_ocean.ConstructFaceLatLon.time_cartesian_averaging('120km')
3.18±0.01ms 3.35±0.02ms 1.05 mpas_ocean.ConstructFaceLatLon.time_cartesian_averaging('480km')
103±0.5ms 102±0.3ms 0.99 mpas_ocean.ConstructFaceLatLon.time_welzl('120km')
9.39±0.07ms 10.6±2ms ~1.13 mpas_ocean.ConstructFaceLatLon.time_welzl('480km')
18.3±0.03ms 18.2±0.2ms 1.00 mpas_ocean.ConstructTreeStructures.time_ball_tree('120km')
925±4μs 959±20μs 1.04 mpas_ocean.ConstructTreeStructures.time_ball_tree('480km')
9.97±0.07ms 9.89±0.04ms 0.99 mpas_ocean.ConstructTreeStructures.time_kd_tree('120km')
609±30μs 599±50μs 0.98 mpas_ocean.ConstructTreeStructures.time_kd_tree('480km')
617±10ms 644±5ms 1.04 mpas_ocean.CrossSections.time_const_lat('120km', 1)
306±2ms 325±2ms 1.06 mpas_ocean.CrossSections.time_const_lat('120km', 2)
159±3ms 165±1ms 1.04 mpas_ocean.CrossSections.time_const_lat('120km', 4)
552±8ms 581±3ms 1.05 mpas_ocean.CrossSections.time_const_lat('480km', 1)
278±3ms 295±3ms 1.06 mpas_ocean.CrossSections.time_const_lat('480km', 2)
142±0.7ms 154±2ms 1.09 mpas_ocean.CrossSections.time_const_lat('480km', 4)
11.4±2ms 11.5±0.4ms 1.01 mpas_ocean.FaceAreas.time_face_areas('120km')
4.03±0.2ms 4.07±0.6ms 1.01 mpas_ocean.FaceAreas.time_face_areas('480km')
229k 229k 1.00 mpas_ocean.FaceAreas.track_nbytes_face_areas('120km')
14.3k 14.3k 1.00 mpas_ocean.FaceAreas.track_nbytes_face_areas('480km')
2.12M 2.12M 1.00 mpas_ocean.FaceAreas.track_peakmem_face_areas('120km')
673k 674k 1.00 mpas_ocean.FaceAreas.track_peakmem_face_areas('480km')
55.4±0.5ms 54.4±0.9ms 0.98 mpas_ocean.GeoDataFrame.time_to_geodataframe('120km', 'exclude')
160±2ms 164±2ms 1.03 mpas_ocean.GeoDataFrame.time_to_geodataframe('120km', 'split')
5.37±0.3ms 5.03±0.2ms 0.94 mpas_ocean.GeoDataFrame.time_to_geodataframe('480km', 'exclude')
31.7±0.3ms 30.6±0.2ms 0.97 mpas_ocean.GeoDataFrame.time_to_geodataframe('480km', 'split')
457k 457k 1.00 mpas_ocean.Gradient.track_nbytes_gradient('120km')
28.7k 28.7k 1.00 mpas_ocean.Gradient.track_nbytes_gradient('480km')
3.2M 3.44M 1.07 mpas_ocean.Gradient.track_peakmem_gradient('120km')
126±3μs 144±6μs ~1.14 mpas_ocean.HoleEdgeIndices.time_construct_hole_edge_indices('480km')
118±0.8μs 140±10μs ~1.19 mpas_ocean.Integrate.time_integrate('120km')
107±0.8μs 113±1μs 1.06 mpas_ocean.Integrate.time_integrate('480km')
18.4M 18.4M 1.00 mpas_ocean.Integrate.track_nbytes_integrate('120km')
1.2M 1.2M 1.00 mpas_ocean.Integrate.track_nbytes_integrate('480km')
106±0.5ms 105±2ms 0.99 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'exclude')
107±2ms 106±1ms 0.99 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'include')
107±0.8ms 105±1ms 0.99 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('120km', 'split')
7.32±0.1ms 7.69±0.2ms 1.05 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'exclude')
7.46±0.2ms 7.45±0.2ms 1.00 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'include')
7.36±0.09ms 7.42±0.05ms 1.01 mpas_ocean.MatplotlibConversion.time_dataarray_to_polycollection('480km', 'split')
263±3ms 261±1ms 0.99 mpas_ocean.NeighborhoodBuild.time_build('120km', 1.0)
541±2ms 544±3ms 1.01 mpas_ocean.NeighborhoodBuild.time_build('120km', 5.0)
14.1±0.04ms 14.1±0.05ms 1.00 mpas_ocean.NeighborhoodBuild.time_build('480km', 1.0)
17.7±0.04ms 17.7±0.07ms 1.00 mpas_ocean.NeighborhoodBuild.time_build('480km', 5.0)
260±1ms 261±2ms 1.00 mpas_ocean.NeighborhoodBuild.time_query_radius('120km', 1.0)
539±3ms 538±3ms 1.00 mpas_ocean.NeighborhoodBuild.time_query_radius('120km', 5.0)
13.7±0.03ms 14.0±0.1ms 1.03 mpas_ocean.NeighborhoodBuild.time_query_radius('480km', 1.0)
17.2±0.02ms 17.2±0.07ms 1.00 mpas_ocean.NeighborhoodBuild.time_query_radius('480km', 5.0)
612.76 612.76 1.00 mpas_ocean.NeighborhoodBuild.track_mean_neighbors('120km', 15.0)
74.17 74.17 1.00 mpas_ocean.NeighborhoodBuild.track_mean_neighbors('120km', 5.0)
37.29 37.29 1.00 mpas_ocean.NeighborhoodBuild.track_mean_neighbors('480km', 15.0)
6.57 6.57 1.00 mpas_ocean.NeighborhoodBuild.track_mean_neighbors('480km', 5.0)
141M 141M 1.00 mpas_ocean.NeighborhoodBuild.track_nbytes_neighbors('120km', 15.0)
17.4M 17.4M 1.00 mpas_ocean.NeighborhoodBuild.track_nbytes_neighbors('120km', 5.0)
563k 563k 1.00 mpas_ocean.NeighborhoodBuild.track_nbytes_neighbors('480km', 15.0)
123k 123k 1.00 mpas_ocean.NeighborhoodBuild.track_nbytes_neighbors('480km', 5.0)
145M 145M 1.00 mpas_ocean.NeighborhoodBuild.track_peakmem_build('120km', 15.0)
21.5M 21.5M 1.00 mpas_ocean.NeighborhoodBuild.track_peakmem_build('120km', 5.0)
824k 824k 1.00 mpas_ocean.NeighborhoodBuild.track_peakmem_build('480km', 15.0)
384k 384k 1.00 mpas_ocean.NeighborhoodBuild.track_peakmem_build('480km', 5.0)
39.9±0.6ms 40.5±0.9ms 1.02 mpas_ocean.NeighborhoodDask.time_mean('120km', 'grid_chunks')
18.0±0.07ms 18.0±0.06ms 1.00 mpas_ocean.NeighborhoodDask.time_mean('120km', 'numpy')
36.4±1ms 36.5±1ms 1.00 mpas_ocean.NeighborhoodDask.time_mean('120km', 'time_chunks')
10.1±0.05ms 9.99±0.1ms 0.99 mpas_ocean.NeighborhoodDask.time_mean('480km', 'grid_chunks')
614±10μs 726±100μs ~1.18 mpas_ocean.NeighborhoodDask.time_mean('480km', 'numpy')
7.01±0.06ms 7.08±0.07ms 1.01 mpas_ocean.NeighborhoodDask.time_mean('480km', 'time_chunks')
5.82M 5.82M 1.00 mpas_ocean.NeighborhoodDask.track_peakmem_mean('120km', 'grid_chunks')
2.75M 2.75M 1.00 mpas_ocean.NeighborhoodDask.track_peakmem_mean('120km', 'numpy')
5.68M 5.67M 1.00 mpas_ocean.NeighborhoodDask.track_peakmem_mean('120km', 'time_chunks')
177k 177k 1.00 mpas_ocean.NeighborhoodDask.track_peakmem_mean('480km', 'numpy')
528k 534k 1.01 mpas_ocean.NeighborhoodDask.track_peakmem_mean('480km', 'time_chunks')
4.89±0.02s 4.96±0.02s 1.01 mpas_ocean.NeighborhoodReduce.time_dataset_reduce('120km', 'mean')
5.00±0.01s 5.19±0.02s 1.04 mpas_ocean.NeighborhoodReduce.time_dataset_reduce('120km', 'median')
127±0.2ms 127±0.5ms 1.00 mpas_ocean.NeighborhoodReduce.time_dataset_reduce('480km', 'mean')
130±0.7ms 131±0.5ms 1.00 mpas_ocean.NeighborhoodReduce.time_dataset_reduce('480km', 'median')
545±1ms 549±2ms 1.01 mpas_ocean.NeighborhoodReduce.time_neighborhood_reduce('120km', 'mean')
585±2ms 587±4ms 1.00 mpas_ocean.NeighborhoodReduce.time_neighborhood_reduce('120km', 'median')
17.7±0.05ms 17.8±0.05ms 1.01 mpas_ocean.NeighborhoodReduce.time_neighborhood_reduce('480km', 'mean')
18.0±0.1ms 18.4±0.07ms 1.02 mpas_ocean.NeighborhoodReduce.time_neighborhood_reduce('480km', 'median')
4.90±0.08ms 5.04±0.01ms 1.03 mpas_ocean.NeighborhoodReduce.time_reduce('120km', 'mean')
41.7±0.4ms 41.6±0.3ms 1.00 mpas_ocean.NeighborhoodReduce.time_reduce('120km', 'median')
151±2μs 150±5μs 0.99 mpas_ocean.NeighborhoodReduce.time_reduce('480km', 'mean')
484±10μs 445±30μs 0.92 mpas_ocean.NeighborhoodReduce.time_reduce('480km', 'median')
234k 234k 1.00 mpas_ocean.NeighborhoodReduce.track_peakmem_reduce('120km', 'mean')
235k 235k 1.00 mpas_ocean.NeighborhoodReduce.track_peakmem_reduce('120km', 'median')
19.5k 19.5k 1.00 mpas_ocean.NeighborhoodReduce.track_peakmem_reduce('480km', 'mean')
19.6k 19.6k 1.00 mpas_ocean.NeighborhoodReduce.track_peakmem_reduce('480km', 'median')
328±20μs 385±10μs ~1.17 mpas_ocean.PointInPolygon.time_face_search_lonlat('120km')
307±10μs 350±30μs ~1.14 mpas_ocean.PointInPolygon.time_face_search_lonlat('480km')
324±8μs 349±20μs 1.08 mpas_ocean.PointInPolygon.time_face_search_xyz('120km')
303±8μs 330±10μs 1.09 mpas_ocean.PointInPolygon.time_face_search_xyz('480km')
93.4±4ms 103±1ms ~1.11 mpas_ocean.RemapDownsample.time_bilinear_remapping
16.7±0.1ms 17.2±0.3ms 1.02 mpas_ocean.RemapDownsample.time_inverse_distance_weighted_remapping
15.5±0.1ms 16.0±0.2ms 1.03 mpas_ocean.RemapDownsample.time_nearest_neighbor_remapping
695±2ms 682±3ms 0.98 mpas_ocean.RemapUpsample.time_bilinear_remapping
7.69±0.1ms 7.84±0.2ms 1.02 mpas_ocean.RemapUpsample.time_nearest_neighbor_remapping
8.11±0.09ms 7.86±0.08ms 0.97 mpas_ocean.ZonalAverage.time_zonal_average('120km')
4.75±0.2ms 4.65±0.06ms 0.98 mpas_ocean.ZonalAverage.time_zonal_average('480km')
1.0424438320004776 1.0608958441513745 1.02 nogil_scaling.GILScaling.track_gil_scaling
2.02±0.04ms 2.40±0.06ms ~1.19 open_dataset.OpenDataset.time_open_dataset('dataset', 'file')
4.41±0.02ms 5.15±0.04ms ~1.17 open_dataset.OpenDataset.time_open_dataset('file', 'dataset')
224±3ms 226±3ms 1.01 plots.PlotHealpix.time_default_plot(6)
2.13±0.01s 2.12±0.01s 1.00 plots.PlotHealpix.time_default_plot(8)
28M 28M 1.00 plots.PlotHealpix.track_peakmem_default_plot(6)
443M 443M 1.00 plots.PlotHealpix.track_peakmem_default_plot(8)
8.04±0.2ms 8.08±0.03ms 1.01 quad_hexagon.QuadHexagon.time_open_dataset
6.63±0.06ms 7.20±0.1ms 1.09 quad_hexagon.QuadHexagon.time_open_grid
408 408 1.00 quad_hexagon.QuadHexagon.track_nbytes_open_dataset
392 392 1.00 quad_hexagon.QuadHexagon.track_nbytes_open_grid
71.3k 71.3k 1.00 quad_hexagon.QuadHexagon.track_peakmem_open_dataset
70k 71k 1.02 quad_hexagon.QuadHexagon.track_peakmem_open_grid
270M 270M 1.00 to_raster.ToRaster.track_peakmem((10000.0, 10.0))
680M 680M 1.00 to_raster.ToRaster.track_peakmem((10000.0, 100.0))
765M 765M 1.00 to_raster.ToRaster.track_peakmem((100000.0, 100.0))

Benchmarks that have got worse:

Change Before [55e15bb] <v2026.10.1~8> After [4a070cc] Ratio Benchmark (Parameter)
+ 352M 390M 1.11 face_bounds.FaceBoundsColdStartRss.track_peakmem_open_and_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/mpas/QU/oQU480.231010.nc'))
+ 352M 390M 1.11 face_bounds.FaceBoundsColdStartRss.track_peakmem_open_and_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/scrip/outCSne8/outCSne8.nc'))
+ 352M 390M 1.11 face_bounds.FaceBoundsColdStartRss.track_peakmem_open_and_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
+ 352M 390M 1.11 face_bounds.FaceBoundsColdStartRss.track_peakmem_open_and_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
+ 352M 390M 1.11 import.Imports.track_peakmem_import_uxarray
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('120km', 1)
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('120km', 2)
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('120km', 4)
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('480km', 1)
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('480km', 2)
+ 353M 390M 1.11 mpas_ocean.CrossSectionsPeakMem.track_peakmem_const_lat('480km', 4)
+ 15.4±0.1ms 21.3±0.4ms 1.39 mpas_ocean.DualMesh.time_dual_mesh_construction('120km')
+ 1.94±0.05ms 2.47±0.02ms 1.27 mpas_ocean.DualMesh.time_dual_mesh_construction('480km')
+ 12.5±0.06ms 13.9±0.3ms 1.11 mpas_ocean.Gradient.time_gradient('120km')
+ 1.61±0.01ms 2.29±0.02ms 1.42 mpas_ocean.Gradient.time_gradient('480km')
+ 204k 226k 1.11 mpas_ocean.Gradient.track_peakmem_gradient('480km')
+ 352M 390M 1.11 mpas_ocean.GradientColdStartRss.track_peakmem_gradient('120km')
+ 352M 390M 1.11 mpas_ocean.GradientColdStartRss.track_peakmem_gradient('480km')
+ 290±10μs 363±10μs 1.25 mpas_ocean.HoleEdgeIndices.time_construct_hole_edge_indices('120km')
+ 352M 390M 1.11 mpas_ocean.ZonalAveragePeakMem.track_peakmem_zonal_average('120km')
+ 352M 390M 1.11 mpas_ocean.ZonalAveragePeakMem.track_peakmem_zonal_average('480km')
+ 996±9μs 1.27±0.03ms 1.27 open_dataset.OpenDataset.time_open_dataset('dataset', 'dataset')
+ 5.31±0.06ms 6.31±0.3ms 1.19 open_dataset.OpenDataset.time_open_dataset('file', 'file')

cmdupuis3 and others added 6 commits September 30, 2026 14:08
… Numba

The robust path built several tiny polars DataFrames per candidate face,
and that fixed per-call overhead was nearly its whole runtime. Each
latitude is now two Numba calls: one computing every candidate face's
longitude intervals, and one running the overlap sweep line. Results are
bit-identical, and robust zonal means are 52-86x faster, now within
1.3-2.7x of the default path instead of 100-200x slower.

Both new per-latitude kernels release the GIL. Each call does milliseconds
of work, so from 4 threads the robust weights take 1.09x the single-thread
wall time instead of 4.03x.

The private helpers now use arrays instead of DataFrames:
_zonal_face_weights_robust returns the weights, _get_zonal_face_interval
returns (start, end) rows, and _process_overlapped_intervals takes
starts/ends/face indices and returns per-face contributions. A face whose
crossing longitudes cannot be paired into intervals now raises ValueError
rather than polars' ShapeError.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmark Run ASV benchmark workflow scalability Related to scalability & performance efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unoptimized routines in integrate.py

1 participant