Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/pannellum/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ declare namespace Pannellum {
* @param sceneId - The ID of the new scene.
* @param config - The configuration of the new scene.
*/
addScene(sceneId: string, config: string): this;
addScene(sceneId: string, config: ConfigOptions): this;

/**
* Remove a scene.
Expand Down
4 changes: 4 additions & 0 deletions types/pannellum/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
{
"name": "Shirsh Zibbu",
"githubUsername": "zhirzh"
},
{
"name": "Kyle Hensel",
"githubUsername": "k-yle"
}
]
}
14 changes: 14 additions & 0 deletions types/pannellum/pannellum-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,17 @@ window.libpannellum.renderer(view);
declare const viewer: Pannellum.Viewer;
viewer.on("scenechange", (id) => console.log("Scene changed to", id));
viewer.off();

viewer.addScene("myScene", {
showFullscreenCtrl: false,
autoLoad: false,
compass: false,
yaw: 0,
type: "equirectangular",
preview: "",
panorama: "",
northOffset: 1.3,
});
viewer.addScene("myScene", {
// test that all properties are optional
});