Skip to content

mod.openchanfix: the DB connection check timer does nothing, and its required config var drives a no-op #99

Description

@MrIron-no

mod.openchanfix/chanfix.cc:399 — the only statement in the DB connection check timer's handler is a commented-out call:

/*checkDBConnection();*/

and checkDBConnection() itself is commented out at mod.openchanfix/chanfix.cc:3338. The timer's entire effect is therefore to re-arm itself every connectCheckFreq seconds; the database connection is never health-checked.

connectCheckFreq is not optional: chanfix.cc:269 obtains it through chanfixConfig->Require("connectCheckFreq"), so the module refuses to start without it, and mod.openchanfix/chanfix.example.conf.in:157 documents it as connectCheckFreq = 10. Operators are therefore required to configure a value that has no effect, and would reasonably believe the connection is being monitored.

Either restore the check, or remove the timer together with the config var and its example entry so the configuration stops promising something the module does not do.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions