FIX: Inset the search field in the "Add supported device" popup so it no longer sits flush against the popup's left edge [UUM-150217] - #2478
Open
Pauliusd01 wants to merge 4 commits into
Conversation
… no longer sits flush against the popup's left edge [UUM-150217] The search field in the "Add supported device" popup drew flush against the popup's left edge with no left margin, while its right edge kept the base field's spacing. InputControlPickerDropdown.InputControlPickerGUI.DrawSearchFieldControl(string searchString) wraps the field in a HorizontalScope whose only leading element (the "Listen" toggle block) is emitted exclusively in PickControl mode, so in PickDevice mode nothing offset the field from the left edge. Added an else branch that emits a GUILayout.Space(3f) when the "Listen" block is absent, giving the field a left inset that matches its right-side spacing and leaving PickControl mode untouched. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150217
…50217] Bump the PickDevice-mode search-field inset in DrawSearchFieldControl from 3px to 8px and remove the explanatory comment. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150217
Add a 3px leading inset before the "Listen" toggle block in DrawSearchFieldControl so it is no longer flush against the popup's left edge in PickControl mode. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150217
…217] Bump the PickControl-mode "Listen" block inset in DrawSearchFieldControl from 3px to 8px so both modes share the same left inset. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-150217
Pauliusd01
marked this pull request as ready for review
August 20, 2026 05:02
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The picker change adds a consistent left-side layout reservation before the search control in each supported picker mode, while the changelog accurately records the editor-only visual fix. I found no actionable defects in the changed behavior or release-note entry.
Reviewed commit 383dcde
🤖 Helpful? 👍/👎
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2478 +/- ##
=========================================
Coverage 78.95% 78.95%
=========================================
Files 767 767
Lines 140780 140907 +127
=========================================
+ Hits 111153 111256 +103
- Misses 29627 29651 +24 Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This pull request was generated automatically. Please review carefully before merging.
InputControlPickerDropdown.InputControlPickerGUI.DrawSearchFieldControl(string searchString)wraps its search field in aHorizontalScopewhose only leading element is the "Listen" toggle block, and that block is emitted exclusively inPickControlmode. InPickDevicemode (the "Add supported device" popup opened from Input System Package Settings > Supported Devices > "+"), there is no leading element, so the search field drew flush against the popup's left edge with no left margin while its right edge kept the base field's spacing.The change emits a
GUILayout.Space(8f)as the first element of theHorizontalScopein both modes: at the start of thePickControlbranch so the "Listen" block is no longer flush against the popup's left edge, and in anelsebranch so the search field inPickDevicemode gets the same left inset (matching its right-side spacing). This is the same family of cosmetic-inset fix as the sibling Supported Devices list fix (UUM-150207).Testing status & QA
Overall Product Risks
Comments to reviewers
N/A
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.