Skip to content

chore: Add NGO_EXCLUDE_HEAVY_TESTS define - #4114

Merged
NoelStephensUnity merged 1 commit into
develop-2.0.0from
ci/ngo-exclude-heavy-tests
Jul 30, 2026
Merged

chore: Add NGO_EXCLUDE_HEAVY_TESTS define#4114
NoelStephensUnity merged 1 commit into
develop-2.0.0from
ci/ngo-exclude-heavy-tests

Conversation

@mnachury-unity

@mnachury-unity mnachury-unity commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Purpose of this PR

Adding a define to exclude the BasicBuildTest which recently started to caused timeout on ubuntu build for 6000.6 and trunk with multiplayer tools weekly due to OOM on the b1.large (8GB) VM.
As we discussed in this thread the better long therme solution will be to have a dedicated place for this test in this epic. But I think we can start by disabling this one in multiplayer tools CI.

Multiplayer tools ci PR here.

Jira ticket

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

We only run NGO-2.X integration test in multiplayer tools.

Backports

We only run NGO-2.X integration test in multiplayer tools.

@mnachury-unity
mnachury-unity requested a review from a team as a code owner July 30, 2026 20:11

@NoelStephensUnity NoelStephensUnity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoelStephensUnity NoelStephensUnity changed the title Add NGO_EXCLUDE_HEAVY_TESTS define chore: Add NGO_EXCLUDE_HEAVY_TESTS define Jul 30, 2026
@NoelStephensUnity
NoelStephensUnity enabled auto-merge (squash) July 30, 2026 20:15
@codecov-github-com

codecov-github-com Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@                Coverage Diff                @@
##           develop-2.0.0    #4114      +/-   ##
=================================================
+ Coverage          73.96%   73.97%   +0.01%     
=================================================
  Files                172      172              
  Lines              28095    28095              
=================================================
+ Hits               20781    20784       +3     
+ Misses              7314     7311       -3     
Flag Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk 73.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 73.97% <ø> (+0.01%) ⬆️

ℹ️ Need help interpreting these results?

@NoelStephensUnity
NoelStephensUnity merged commit 3119706 into develop-2.0.0 Jul 30, 2026
30 of 34 checks passed
@NoelStephensUnity
NoelStephensUnity deleted the ci/ngo-exclude-heavy-tests branch July 30, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants