feat: add SDK 9.x migration support to the LevelPlay skill - #29
Open
ziyiunity wants to merge 2 commits into
Open
feat: add SDK 9.x migration support to the LevelPlay skill#29ziyiunity wants to merge 2 commits into
ziyiunity wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds guided SDK 9.x migration to the LevelPlay skill, so a developer arriving with an existing IronSource or older LevelPlay integration gets a path forward instead of instructions written for a fresh install.
What lands
references/migration-sdk-9.md(666 lines) covers five scenarios: SDK upgrade by.unitypackageor UPM including switching between the two, init API migration offIronSource.Agent, ad unit API migration per format, Maven Central dependency build failures, and Unity Ads migration. It ends with a completeness checklist for the requirements a line-by-line translation misses, because the legacy code had no equivalent line to translate: placement capping checks, an explicit rewarded load trigger, correct ILRD event names,HideAdversusDestroyAdintent for legacydestroyBannercalls, and removal ofonApplicationPause.SKILL.mdgains a Step 0 that asks whether this is a new integration, a migration, or troubleshooting, before any other question. Getting that wrong early is expensive: a migration walked through the new-integration path ends up with a second parallel setup rather than a converted one.Also in
SKILL.md: a troubleshooting row for Android builds that suddenly fail resolvingcom.ironsource.sdkfromandroid-sdk.is.com, which is the signature of that repository being shut down and dependencies having moved to Maven Central; a pointer from the deprecated-API branch to the new reference; and the placement-capping requirement added to the code-generation rules.Five reference files take corresponding updates:
banner-api.md,best-practices.md,initialization-api.md,interstitial-api.md,privacy-settings.md. The banner fix is worth naming: the adaptive-size example used a constructor form that does not compile on any 9.x version, and is now configured throughConfig.Builder.How
SKILL.mdwas editedSurgically, four insertions, rather than replaced wholesale. The install-verification gate at Step 3 and the
CS0246material inreferences/troubleshooting.mdare unchanged and were not in scope here.Step 0 asks the user to check the Unity console for compilation errors rather than naming a tool to run. No skill in this set invokes a CLI or drives the Editor, and a step that names a mechanism the agent cannot reach is worse than a step that names none: the agent will try it, fail, and either stall or invent a substitute. It is also written not to block when the console cannot be seen, so the run ends with a list of changed files and what to look for.
Checked
references/*.mdmentioned in the body exist, and every file present is reachable from the body. No orphans in either direction.references/migration-sdk-9.mdis byte-identical to the copy inUnity-Technologies/skills.best-practices.mdis the largest churn in the diff and it is a genuine reordering, not a whitespace artifact: 604 lines, no CRLF.