Repository navigation
fix: end multipart responses with the closing boundary - #592
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
No issues found across 4 files
Shadow auto-approve: would not auto-approve. This PR does not meet the repository auto-approval settings.
View guided diff | Re-trigger cubic
|
Automated review, forwarded by @paulkarayan. Findings are code-verified where they name a file and line; the strong-review gpt-pro leg and cubic did not run. GO -- 0 blocker(s), 0 concern(s), 2 note(s), 0 nit(s). Correct, spec-conforming fix: multipart responses now end with the closing boundary; needs a rebase and a new version number since main took 0.1.12. Notes (2)
Full review |
What
multipart/mixedresponses now end with the closing boundary line that the MIME format requires.Why
Without the closing line, strict multipart parsers report the response as incomplete. If processing fails partway through, the closing line is still left out, so clients can tell a cut-off response from a complete one.
Validation
Tests parse the response with Python's
emailparser (no defects) for one part, several parts, and no parts, and cover an interrupted stream. They fail onmain. Adds a CHANGELOG entry and bumps the version to 0.1.15.Refreshed against main after #590 and #591 merged. Targeted API tests: 43 passed; response compatibility tests: 4 passed. Changed-source lint passed.