fix: run dependent detection stages sequentially - #10
Open
BaoZhiFei wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
单个域名的网络检测阶段共享并修改同一个
DetectionResult,且阶段之间存在数据依赖。例如 TLS 检测依赖重定向后的最终域名,热门网站检测依赖
Network 和 CDN 结果。
当前实现并发执行这些阶段,不仅会导致数据竞争,也可能让后续阶段在前置
结果尚未生成时开始检测。
修改
验证
go test ./...go test -race ./internal/corego vet ./...git diff --check