[HL2MP] Use all spawn points for the initial spawn - #2066
Open
speedvoltage wants to merge 1 commit into
Open
speedvoltage wants to merge 1 commit into
speedvoltage wants to merge 1 commit into
Conversation
Issue: With no previous spawn point, the random advance is limited to the first five spawn entities. Maps with more than five valid spawns, including dm_lockdown, cannot initially select the remaining points. Fix: Use the full spawn-point count for the initial selection of the chosen spawn class, while retaining the existing advance range for subsequent spawns and the validity and fallback checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
With no previous spawn point, selection advances only 1–5 entries through the spawn entities. On maps with more than five valid points, such as
dm_lockdownwith nine (or more on the newer updated version of the game), the remaining points cannot be selected for the initial spawn when the first five are valid. This issue was documented here ValveSoftware/Source-1-Games#6760Fix:
In the past, I delayed the initial spawn as documented on #1037 and this also fixed the 0,0,0 angle issue on #2065. This, however, was not ideal. Therefore, the new fix is to use the full count of the selected spawn class for the initial random selection, including team spawn classes. Preserve the existing selection range for subsequent spawns and the validity and fallback checks.