[HL2MP] Enable radio style menus - #2070
Open
speedvoltage wants to merge 4 commits into
Open
speedvoltage wants to merge 4 commits into
speedvoltage wants to merge 4 commits into
Conversation
Issue: HL2MP's numbered menus lack the HUD resources and input handling needed for plugin menus. Fix: Enable ShowMenu rendering with correct selection keys, fragment assembly and menu lifetimes. Add archived cl_radio_menus, enabled by default, so each player can choose HUD radio menus or an ESC dialog.
Issue: ESC menus waste space and reset their position. Fix: Use a compact styled dialog and save its screen position.
Issue: New ESC menu pages reset after dragging, and their custom styling differs from GameUI. Fix: Save the current position before layouts and on HUD ticks. Use the native GameUI scheme, frame, fonts and controls.
Issue: Disabling radio menus leaves pending dialogs hidden without a HUD prompt. Fix: Show a top-left ESC reminder while a dialog menu is waiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a long standing issue. Radio menus have never been enabled in HL2DM and menus as a whole rely on an outdated design, and even got broken in the anniversary update without a client-side fix. Besides,
cl_showpluginmessagesdefaults to 0, which does not help as well.This PR is therefore simple. Enable those radio menus for better and quicker admin access.
The advantage here is that this does not need to rely on
cl_showpluginmessages. Those menus will show regardless of the value of this cvar.Bonus: I might be in the minority here, but I hate the radio menus, just because it interfered in gameplay way back in the CSS days when RTV menus opened during a firefight or when an admin decided to initiate a vote and you wanted to hit 1, 2 or 3 to switch weapons but instead interacted with the menu. So I added
cl_radio_menusso that when disabled, it goes back to using the menu panels. However, I also redesigned those panels to also not have to deal withcl_showpluginmessages.