Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MvM upgrade panel persisting after a server change
In MvM, the upgrade panel can be opened by pressing the inspect key (
Fby default) to view upgrades or by touching an upgrade station zone to buy them. If the player changes servers without closing the panel, it can remain visible with state from the previous server.Note
This does not transfer purchased upgrades between servers. Only the upgrade panel remains visible; the upgrades themselves are still server-side.
Video
YouTube demonstration
Cause and fix
This happened because
CHudUpgradePaneldid not overrideLevelShutdown(). It therefore used the defaultCHudElementhandler, which returns without cleaning up any panel state:This change overrides the method to clear and hide the panel during level shutdown. It calls
CHudElement::SetActive(false)directly to avoid sendingMvM_UpgradesDonewhile leaving the server.