[TF2] Fix Festivizer not attaching to jigglebones correctly in Loadout screen and other UI contexts - #2086
Open
Piogre wants to merge 1 commit into
Open
[TF2] Fix Festivizer not attaching to jigglebones correctly in Loadout screen and other UI contexts#2086Piogre wants to merge 1 commit into
Piogre wants to merge 1 commit into
Conversation
…eview The loadout edit preview and other contexts (such as class select, lower-left HUD, scoreboard) use CTFPlayerModelPanel to render a simulacrum of the player with their current loadout. This module currently takes a shortcut for weapon attachment models by attaching everything directly to the player model. This has one side effect of attachment models failing to attach to jigglebones on their respective wepaons. This PR fixes this issue, rendering attachment models more similarly to how the statclock is already rendered, merging it to the weapon model so that it attaches correctly to jigglebones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In-game, weapon attachments (such as the Festivizer model) merge to the skeleton of the weapon in question, and as such will follow the jigglebone motions of the base weapon to stay visibly attached.
However, the Loadout screen and other UI contexts that display the player model (the lower-left HUD, the Scoreboard, the class-select screen) do not attach these attachment models do the weapon, just to the player model. As a result, weapons with jigglebones do not have the attachment bind correctly to the jigglebones in these contexts.
This PR reworks how attachment models get rendered in playermodelpanel, making them behave more similarly to the strange stat clock (and more similarly to how they attach in the individual weapon preview panels) so that the attachments get properly merged to the weapons' jigglebones, and thus attach correctly to their weapons in these contexts.
Fixes ValveSoftware/Source-1-Games#8062