Repository navigation
add support for yarn lockfile version 9 and 10 - #34
Merged
Merged
Conversation
Owner
|
Hi & thanks for the PR. From the changes it looks like the same parser can handle all 3 lockfile formats. so i think updating yarn should be a separate PR. And instead of overriding it propably makes more sense to just update nixpkgs. |
Keep this PR limited to accepting yarn berry lockfile versions 9 and 10 in the parser. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Thanks! Makes sense. I've reduced this PR to just the parser change, since the existing parser handles versions 9 and 10 as-is. I'll open a separate PR that updates nixpkgs (which now has yarn-berry 4.18.0) and moves the yarn-berry fixture to lockfile version 10, so it's covered in CI. |
Owner
|
Merged. Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the newer yarn versions where the lockfile version changed and an error was thrown since the support was to version 8 . I added 9 and 10 to it. For the check i had to overwrite the pinned yarn version, as stated in the comment.
Hopefully it helps!