fix(score-sets): only reuse meta-analysis experiments the caller can add to - #894
Merged
bencap merged 1 commit intoSep 28, 2026
Conversation
Merged
Coverage Report for CI Build 36474966982Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 88.804%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a user creates a meta-analysis, the new score set was placed in whichever existing meta-analysis experiment covered the same experiment sets, whether or not the user was allowed to add score sets to it. Now an existing experiment is reused only if the caller has
ADD_SCORE_SETpermission on it. If the only matching experiment belongs to another user and is private, the request fails with 409, because an experiment set can hold only one meta-analysis experiment.find_meta_analyses_for_experiment_setsnow returns its results in ID order, so the reused experiment is always the same one.Tests
tests/routers/test_score_set.pycovers joining another user's published meta-analysis experiment, not reusing another user's private one across multiple experiment sets, and the 409 for a single experiment set.