Fix PDB import applying stack based variables without handling stack re-use - #8497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locals are "locals" they are scoped, we don't however carry over that scoping and thus cause variables which re-use a stack offset to clobber one another once PDB information is applied. This causes a myriad of analysis issues and for now should be removed until we can either selectively disable application in those cases, or correctly scope the variable application.
Before (The regression from 5.3):
After (Commits reverted, as it was in 5.3):
Notice the usage of
remoteFileServerAddressandf_variables.For the binary see
supplementary chase crown