Skip to content

fix(vtable-editors): avoid list editor HTML injection - #5273

Merged
fangsmile merged 3 commits into
developfrom
fix/vtable-editors-list-xss
Aug 14, 2026
Merged

fix(vtable-editors): avoid list editor HTML injection#5273
fangsmile merged 3 commits into
developfrom
fix/vtable-editors-list-xss

Conversation

@fangsmile

Copy link
Copy Markdown
Contributor

Summary

  • Build list editor options with DOM APIs instead of assigning user-controlled values through innerHTML
  • Preserve option values, labels, and selected state while avoiding HTML parsing

Test plan

  • Ran git diff --check
  • npm run compile in packages/vtable-editors was not runnable in this environment because tsc is unavailable

🤖 Generated with Claude Code

Create list editor options with DOM APIs so configured values are treated as text instead of parsed as HTML.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Add a focused regression test for malicious list editor option values so the XSS fix stays protected.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Expose a standard test command so the editor regression suite can be run directly by CI and maintainers.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
@fangsmile
fangsmile merged commit 409e634 into develop Aug 14, 2026
7 of 8 checks passed
@fangsmile
fangsmile deleted the fix/vtable-editors-list-xss branch August 14, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant