Skip to content

refactor(TeacherAPIController): Extract and refactor TeacherRegistrationAPIController #334

Merged
hirokiterashima merged 4 commits into
developfrom
refactor-teacher-registration
Jul 21, 2026
Merged

refactor(TeacherAPIController): Extract and refactor TeacherRegistrationAPIController #334
hirokiterashima merged 4 commits into
developfrom
refactor-teacher-registration

Conversation

@Aaron-Detre

@Aaron-Detre Aaron-Detre commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Moved createTeacherAccount method into new TeacherRegistrationAPIController class.
  • Refactored createTeacherAccount and helper methods.
  • Moved related tests into new TeacherRegistrationAPIControllerTest class.

Test

  • Everything should work the same as before. My local environment doesn't have Google/Microsoft accounts or ReCaptcha, so I haven't been able to test those cases. I tried not to change any functionality, so I think it should all still work.
  • A welcome email should still be sent when you create a new account.

@Aaron-Detre Aaron-Detre self-assigned this Jul 17, 2026
@Aaron-Detre Aaron-Detre added the Code Quality Improves code quality label Jul 17, 2026
@Aaron-Detre
Aaron-Detre marked this pull request as ready for review July 17, 2026 17:43
hirokiterashima
hirokiterashima approved these changes Jul 21, 2026
View reviewed changes

@hirokiterashima hirokiterashima left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hirokiterashima
hirokiterashima merged commit 9c77669 into develop Jul 21, 2026
2 checks passed
@hirokiterashima
hirokiterashima deleted the refactor-teacher-registration branch July 21, 2026 00:52
@hirokiterashima

hirokiterashima commented Jul 21, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.21.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

Code Quality Improves code quality released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aaron-Detre @hirokiterashima