Skip to content

widgets-left ignores center option when panel doesn’t span the full edge #595

Open

Description

@AKArien

With center enabled and full_span disabled, the widgets of widgets-left are then aligned to the left of the panel, as opposed hugging the widgets of widgets-center.

This appears to have been messed up by commit f67b883.

Erroneous, current behaviour (on master, as of the previously mentioned commit) : Image

Intended behaviour (anything prior) : Image

Activity

  1. mrsteve0924 commented on Nov 11, 2026

    @mrsteve0924
    Contributor

    I'm confused. if a widget is in widgets-left it will align to the left which is what your first image shows.

    having full_span=false always behaved weirdly for me especially with panels on dual monitors. like it doesnt refresh or reconfigure layout properly. i use full_span=true mostly though.

  2. changed the title [-]widgets-left is aligned to the left when panel doesn’t span the full edge (as opposed to being aligned right)[/-] [+]widgets-left ignores center option when panel doesn’t span the full edge[/+] on Nov 11, 2026
  3. AKArien commented on Nov 11, 2026

    @AKArien
    CollaboratorAuthor

    I'm confused. if a widget is in widgets-left it will align to the left which is what your first image shows.

    My bad, i forgot to mention the center option and have now edited it.

    Looking at the commit, it appears to be because it messes with the expand properties. I’m quite unsure that special-case-ing for the window-list widget is the solution. I see you’ve been the author of most changes relating to it, what exactly was the purpose of the special-case expansion ? things seem to work just fine by my understanding without it ? with this patch applied, i get this :

    Horizontal, center = true, full_span = false
    image

    Horizontal, center = false, full_span = false
    image

    Horizontal, center = false, full_span = true
    image

    Horizontal, center = true, full_span = true
    image

    Where the only thing that looks wrong/unexpected is due to the button of window-list taking more space than in text, which is addressed in #591 to my understanding, and in any case unrelated to the issue at hand.

  4. mrsteve0924 commented on Nov 11, 2026

    @mrsteve0924
    Contributor

    for me, after making any change to wf-shell,ini, the window-list buttons i had in widgets_left would overlap the widgets in widgets_right instead of dynamically resizing to make room. f67b883 was an attempt to fix that but i see it also removes the extra widgets_ spacing when using the center option.

  5. mrsteve0924 commented on Nov 11, 2026

    @mrsteve0924
    Contributor

    @AKArien your pacth works for me.

    EDIT: well now i get these dots for window-list if it's in widget_center. doesnt happen if it's in widgets_left or _right

    2026-11-11_12:38:01
  6. AKArien commented on Nov 11, 2026

    @AKArien
    CollaboratorAuthor

    @mrsteve0924 that’s odd, i’m not seeing it. Are you on master + my patch ? Can you please share your whole panel configuration, or a minimal one for reproducing the issue ? Might be a matter of CSS ?

    ah, never mind, it occurs if it’s the only widget in a widgets_something. Same occurs if you use widgets_left = window-list

  7. mrsteve0924 commented on Nov 11, 2026

    @mrsteve0924
    Contributor

    @mrsteve0924 that’s odd, i’m not seeing it. Are you on master + my patch ? Can you please share your whole panel configuration, or a minimal one for reproducing the issue ? Might be a matter of CSS ?

    ah, never mind, it occurs if it’s the only widget in a widgets_something. Same occurs if you use widgets_left = window-list

    ah the only widget in a widgets_. man, just a lot of variables to consider when working with the panel

  8. mrsteve0924 commented on Nov 11, 2026

    @mrsteve0924
    Contributor

    im wondering if it's necessary to even have widgets_{left,center,right}. ive only really used xfce and its panel, and you just put widgets where you want. maybe some separators to get spacing where you want. just a thought.

  9. AKArien commented on Nov 11, 2026

    @AKArien
    CollaboratorAuthor

    im wondering if it's necessary to even have widgets_{left,center,right}. ive only really used xfce and its panel, and you just put widgets where you want. maybe some separators to get spacing where you want. just a thought.

    Well, they serve for alignment. I do share the feeling, maybe we could have something based on a concept of « anchors », but that would be a big change.

  10. mrsteve0924 commented on Nov 12, 2026

    @mrsteve0924
    Contributor

    maybe just revert f67b883 if it brings back the correct behavior. i can just go back to restarting the panel to reset window-list if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions