Skip to content

Allow atomic operations on non-shared memory in SafeHeap #8890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschuff wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Allow atomic operations on non-shared memory in SafeHeap #8890

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/passes/SafeHeap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@ struct SafeHeap : public Pass {
}

bool
isPossibleAtomicOperation(Index align, Index bytes, bool shared, Type type) {
return align == bytes && shared && type.isInteger();
isPossibleAtomicOperation(Index align, Index bytes, bool /*shared*/, Type type) {

@tlively tlively Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any human or bot gets a chance to look at this, please remove the newly unused parameter.

return align == bytes && type.isInteger();
}

void addGlobals(Module* module, FeatureSet features) {
Expand Down
Loading