fix(nextjs): withBotProtection honours mode and monitors by default - #55
Merged
Merged
Conversation
It ignored mode and refused any request protect() did not allow, while withWebDecoy and every other adapter monitor by default. A Pages API route wrapped with no mode was blocking on install. It now runs the handler in monitor mode with the verdict on req.webdecoyDecision; mode: 'enforce' refuses.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withBotProtectionignoredmodeand returned 403 for any requestprotect()didn't allow.withWebDecoyand every other adapter monitor by default, so a Pages API route wrapped without a mode was blocking from install.req.webdecoyDecision.allowedrecords what enforce would have done.mode: 'enforce'refuses the request.with-bot-protection.test.tscovers both modes. I confirmed it fails without the fix.Behaviour change: anyone who relied on the wrapper blocking needs to add
mode: 'enforce'. The CHANGELOG says so.All tests pass: 566 across 6 packages. Lint and the edge check pass.